feat(@clayui/date-picker): add props to control expand functionality #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 111789209
💛 - Coveralls |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ec1255:
|
bryceosterhaus
changed the title
Comment on lines
252
to
264
| const setExpanded = (val: boolean) => { | ||
| if (expanded !== val && onExpandedChange) { | ||
| onExpandedChange(val); | ||
| } | ||
|
|
||
| setInternalExpanded(val); | ||
| }; | ||
|
|
||
| React.useEffect(() => { | ||
| if (expanded !== undefined) { | ||
| setInternalExpanded(expanded); | ||
| } | ||
| }, [expanded]); |
There was a problem hiding this comment.
Perhaps we can decrease the use here of useEffect which could happen a double rendering due to the useState that the developer will have to use to control. I'm thinking of something like this:
const expanded = externalExpanded !== undefined ? externalExpanded : internalExpanded;
const setExpanded = onExpandedChange ? onExpandedChange : setInternalExpanded;externalExpanded can only be an alias of expanded prop. What do you think? it's makes sense for you?
There was a problem hiding this comment.
@matuzalemsteles let me try that out. That was my goal but my first iteration was having issues. Let me look again to see if this is possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3262