fix(@clayui/css): Mixins clay-label-size and clay-label-variant convert to use new (easier to remember) Sass map keys. The old keys will still work and win over new keys.
#4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onvert to use new (easier to remember) Sass map keys. The old keys will still work and win over new keys. fixes liferay#4069
8 tasks
matuzalemsteles
approved these changes
May 17, 2021
There was a problem hiding this comment.
LGTM! Overall it looks good, @pat270 since we adopted a more nested map, can this add some extra cost on build time?
|
@matuzalemsteles Yes, I think I added around ~3s to build time. This is including Edit: This has been in DXP for a while, I haven't received any reports complaining about CSS build time. 🤞 |
|
LGTM |
|
@pat270 don't worry, thanks, just something to keep an eye on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4069