Add support for formatting TypeScript #96
Labels
Comments
wincent
added a commit
that referenced
this issue
Sep 30, 2020
Note that the goal here is to format and lint TypeScript in liferay-portal, but we're "dog-fooding" in this monorepo already, even though there isn't any TypeScript in here (yet... when we bring across the js-toolkit packages TypeScript will start coming in here too). Note how we can lint JS just fine with the TS parser. Closes: #96
wincent
added a commit
that referenced
this issue
Dec 18, 2020
Combined everybody's input from the original issue. No enforcement (linting) for this stuff yet, and we may not need it unless we find that we have consistency problems. Closes: liferay/liferay-frontend-guidelines#96
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue type
Description
Desired behavior:
liferay-npm-scripts checkFormat(andformat) should handle TypeScript.Current behavior:
The format tasks only deal with JS (etc).
This is a known-limitation that we didn't address when we rolled out TypeScript files in the
remote-app-client-jsmodule in liferay-portal, but it can lead to confusion (as evidenced here) and it's a gap we don't won't to leave lying around anyway.The text was updated successfully, but these errors were encountered: