Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(liferay-cli): add new 'theme spritemap' target type #1104

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

bryceosterhaus
Copy link
Member

@bryceosterhaus bryceosterhaus commented Mar 16, 2023

note, I added "(Experimental)" to the name, this way we don't have to make any grand promises :trollface:

image

I realized we still use "remote app" for naming stuff. Not sure if I should update that or just use "client extension" now and migrate those later.

@izaera
Copy link
Member

izaera commented Mar 16, 2023

Woa, I never thought anyone could understand all the facets, target, etc, stuff without asking me and/or swearing 😅

Very good job 👍

note, I added "(Experimental)" to the name, this way we don't have to make any grand promises :trollface:

We should add experimental everywhere. We should make a GH action to SF all static labels and add the suffix (experimental) to all of them 💪

I realized we still use "remote app" for naming stuff. Not sure if I should update that or just use "client extension" now and migrate those later.

Technically, "remote app" is one of "custom element client extension" or "iframe client extension" so you can also call any "remote app" a "client extension" => yes, we can stop using "remote apps" and replace it by "client extension" if that makes our lives easier.

@izaera
Copy link
Member

izaera commented Mar 16, 2023

The windows tests are failing since yesterday, when I pushed a commit directly (bc it only modified a GH issue template) and I'm not sure if it is due to a stale yarn cache... 🤔

They also were flaky due to an intermitent timeout that happened only in Windows. Maybe my commit has stabilized the timeout (for the bad)...? 🤷

@bryceosterhaus
Copy link
Member Author

Woa, I never thought anyone could understand all the facets, target, etc, stuff without asking me and/or swearing

it was actually pretty straight forward and easy to add, so well done on the initial implementation!

@bryceosterhaus bryceosterhaus merged commit 082c1c2 into liferay:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants