Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exchange flipping and style evaluation order to avoid css flicker #1188 #1189

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

NemethNorbert
Copy link
Member

@NemethNorbert NemethNorbert commented Jan 18, 2024

Hello,

Issue:
🐛 Bug report

Description
LPS-206518

Desired behavior:
Applied Style book's style remain unchanged during navigation

Current behavior:
Applied Style book's style changes during navigation as it is overridden by theme's style

Other information (environment, versions etc):
Reproducible on Liferay 7.3.x and lower

The same fix has been applied to senna within the DXP code base on 7.4 under LPS-202135

@github-actions github-actions bot added the senna label Jan 18, 2024
@NemethNorbert NemethNorbert changed the title Fix: Exchange flipping and style evaluation order to avoid css flicker #1188 fix: Exchange flipping and style evaluation order to avoid css flicker #1188 Jan 18, 2024
@bryceosterhaus
Copy link
Member

@NemethNorbert how come this change is being added here? To support older liferay versions, wouldn't we just backport the frontend-js-spa-web module?

@NemethNorbert
Copy link
Member Author

Hey @bryceosterhaus ,

I believe the main reason we have senna in this repo is that we are able to make changes in it and apply it to our older versions. As in 7.3 and older DXP versions senna is not integrated into the frontend-js-spa-web module. It was done for 7.4 under LPS-122511. I think backporting LPS-122511 and all the changes after it would be a larger task than releasing a new version of senna for the older versions of DXP. However this question is probably for the Frontend Infrastructure Dev Team and not me.
Right now based on the Repo Description if we want to introduce a change in SPA for 7.3 and lower DXP versions, we should do it trough this repo.

@bryceosterhaus bryceosterhaus merged commit d969b13 into liferay:master Jan 25, 2024
7 of 8 checks passed
@bryceosterhaus
Copy link
Member

@NemethNorbert published under 2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants