style(senna): fix linting errors

[izaera]

Just that!

[diegonvs]

LGTM

[bryceosterhaus]

Just had one part I think we need to address, but the others look good.

I'm impressed you went through the trouble of updating all the should in tests. I would've just turned off that rule inside of senna...

[izaera]

I'm impressed you went through the trouble of updating all the should in tests.

😂 I made a vim macro for that: remove should, move one word right, add an s. That made it for 90% of the tests since English behaves as a good language in this case.

Otherwise I would have changed eslint config, most probably 🙄

One funny thing I noticed is that someone, at some moment in time, had to add some shoulds, because of how they were written in some of the tests (incorrectly) 🎉

[izaera]

Ready to go 🚀

I had to forcepush to avoid a "fabricated" fix semantic commit that would have appeared in the changelog, maybe.

[izaera]

I'll merge this since I've fixed this issue and the rest was approved.