Make sure only the first define() is namespaced

packages/babel-plugin-namespace-amd-define/src/__tests__/__snapshots__/index.test.js.snap

@@ -9,3 +9,13 @@ exports[`does not namespace already qualified define calls 1`] = `
 "
 Other.Namespace.define([], function () {});"
 `;
+
+exports[`only namespaces the first appearance of define() in the source 1`] = `
+"
+if (window.define) {
+ Liferay.Loader.define([], function () {
+ console.log(define('this should not be namespaced'));
+ });
+}
+Liferay.Loader.define('this should not be namespaced');"
+`;

packages/babel-plugin-namespace-amd-define/src/__tests__/index.test.js

@@ -24,3 +24,27 @@ it('does not namespace already qualified define calls', () => {
 
  expect(code).toMatchSnapshot();
 });
+
+// It is not clear what would be the best way to handle multiple define calls in
+// the code.
+// On the one hand, it is faster to only change the first appearance as 99% of
+// the time we will be processing AMD modules with define calls issued by us.
+// On the other hand, some third party modules (like jQuery, for instance) issue
+// define() calls inside their code. We expect only one such call, but if
+// someone does anything more exotic than that, this plugin could "fail".
+it('only namespaces the first appearance of define() in the source', () => {
+ const source = `
+ if(window.define) {
+ define([], function() {
+ console.log(define('this should not be namespaced'));
+ });
+ }
+ define('this should not be namespaced')
+ `;
+
+ const { code } = babel.transform(source, {
+ plugins: [plugin],
+ });
+
+ expect(code).toMatchSnapshot();
+});

packages/babel-plugin-namespace-amd-define/src/index.js

@@ -5,7 +5,11 @@
  */
 export default function({ types: t }) {
  const namespaceVisitor = {
- ExpressionStatement(path) {
+ ExpressionStatement(path, state) {
+ if (state.namespaced) {
+ path.stop();
+ }
+
  const node = path.node;
  const expression = node.expression;
 
@@ -17,6 +21,7 @@ export default function({ types: t }) {
 
  callee.name = `${namespace}.define`;
 
+ state.namespaced = true;
  path.stop();
  }
  }