Return a dummy PluginLogger if none is registered.

Fixes #85
liferay · Mar 14, 2018 · f2fd122 · f2fd122
1 parent 704adeb
commit f2fd122
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/liferay-npm-build-tools-common/src/__tests__/plugin-logger.test.js b/packages/liferay-npm-build-tools-common/src/__tests__/plugin-logger.test.js
@@ -37,10 +37,18 @@ describe('when using PlugginLogger registration', () => {
 
  PluginLogger.set('a-key', logger);
 
- expect(PluginLogger.get('a-key')).toBe(logger);
+ logger.info('source', 'hi');
+
+ expect(PluginLogger.get('a-key').messages.length).toBe(1);
+
+ PluginLogger.delete('a-key');
+
+ expect(PluginLogger.get('a-key').messages.length).toBe(0);
+ });
 
+ it('returns a dummy logger if no loggers are registered', () => {
  PluginLogger.delete('a-key');
 
- expect(PluginLogger.get('a-key')).toBeUndefined();
+ expect(PluginLogger.get('a-key')).toBeDefined();
  });
 });
diff --git a/packages/liferay-npm-build-tools-common/src/plugin-logger.js b/packages/liferay-npm-build-tools-common/src/plugin-logger.js
@@ -98,7 +98,7 @@ PluginLogger.get = function(key) {
  key = key.file.opts.filenameRelative;
  }
 
- return global._PluginLogger_[key];
+ return global._PluginLogger_[key] || new PluginLogger();
 };
 
 /**