This repository was archived by the owner on Oct 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
feat: Prepare a new snapshot version to integrate in Portal's build #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that we can tell the user what webpack and/or our plugins are doing on each file.
Apparently webpack supports ES6 imports out of the box, thus our imports loader must understand and transform them correctly.
This is to make spurious build problems disappear. We don't need specialized scripts for these tasks any more, as tsc project references feature does the trick. Build is a bit slower than with our specialized script, but not so slower as to justify staying out of the blessed way of building Typescript projects.
This is needed because the project stopped building correctly due to the new build configuration.
wincent
reviewed
Mar 10, 2020
wincent
reviewed
Mar 10, 2020
wincent
reviewed
Mar 10, 2020
packages/liferay-npm-bundler/src/steps/webpack/plugin/imports-loader.ts
Outdated
Show resolved
Hide resolved
wincent
reviewed
Mar 10, 2020
wincent
reviewed
Mar 10, 2020
wincent
reviewed
Mar 10, 2020
wincent
reviewed
Mar 10, 2020
This is to prevent people from shooting at their feet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.