Skip to content
This repository has been archived by the owner on Oct 17, 2020. It is now read-only.

Add babel-plugin-namespace-amd-define #5

Merged
merged 3 commits into from
Jul 10, 2017
Merged

Add babel-plugin-namespace-amd-define #5

merged 3 commits into from
Jul 10, 2017

Conversation

izaera
Copy link
Member

@izaera izaera commented Jul 10, 2017

No description provided.

@izaera izaera requested a review from jbalsas as a code owner July 10, 2017 10:39
jbalsas
jbalsas suggested changes Jul 10, 2017
View reviewed changes
Copy link
Contributor

@jbalsas jbalsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @izaera, this looks good, maybe missing a couple of tests for:

  • define calls inside the top-level define
  • define calls with different number of arguments

Could you figure out which make sense and add on top?

Thanks!

@jbalsas jbalsas merged commit 6550dc4 into liferay:master Jul 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbalsas jbalsas jbalsas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@izaera @jbalsas @ivan-zaera