This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
chore: update for compliance with current Outbound Licensing Policy #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is analogous to the one I just made in: liferay/eslint-config-liferay#151 It updates the license header format to match the latest policy: https://grow.liferay.com/excellence/Liferay+Outbound+Licensing+Policy Did this by updating `copyright.js`, running `yarn lint:fix`, and then applying manual fixes to the three `bin` files (because of their use of "shebang" lines, the linter adds a redundant copy of the header). I used a Vim macro to reset the year to its original value (2019) instead of letting the linter update it to 2020.
As required by the Outbound Licensing Policy: https://grow.liferay.com/excellence/Liferay+Outbound+Licensing+Policy I forgot to do this in the previous commit.
wincent
added a commit
to liferay/liferay-js-themes-toolkit
that referenced
this pull request
Feb 24, 2020
This change is analogous to the one I just made in: - liferay/eslint-config-liferay#151 - liferay/liferay-npm-tools#394 It updates the license header format to match the latest policy: https://grow.liferay.com/excellence/Liferay+Outbound+Licensing+Policy Did this by updating `copyright.js`, preserving the original year, running `yarn lint:fix`, and then applying manual fixes in the `bin` files (because of its use of "shebang" line, the linter adds a redundant copy of the header). I used a Vim macro to strip out the original headers. Finally, I changed the hardcoded year in the copyright.js template (2017) to a `<%= YEAR %>`, so that subsequently created files will use the current year. Adds a copy of the license to `LICENSES/MIT.txt`.
This was referenced Feb 24, 2020
wincent
added a commit
to liferay/alloy-editor
that referenced
this pull request
Feb 24, 2020
This change is analogous to the one I made in: - liferay/eslint-config-liferay#151 - liferay/liferay-npm-tools#394 - liferay/liferay-js-themes-toolkit#441 - liferay/clay#2947 It updates the license header format to match the latest policy: https://grow.liferay.com/excellence/Liferay+Outbound+Licensing+Policy Did this by updating `copyright.js` and running `yarn lint:fix`. I used a Vim macro to strip out the original headers. I then edited the template to use a dynamic `<%= YEAR %>` instead of hard-coded 2014, so that any subsequently created files will use the year of creation. Adds a copy of the license to `LICENSES/LGPL-3.0-or-later.txt` as required by the policy too.
This was referenced Feb 24, 2020
Merged
Merged
|
Just comment changes, so merging. |
bryceosterhaus
pushed a commit
to bryceosterhaus/clay
that referenced
this pull request
May 19, 2020
This change is analogous to the one I made in: - liferay/eslint-config-liferay#151 - liferay/liferay-npm-tools#394 - liferay/liferay-js-themes-toolkit#441 It updates the license header format to match the latest policy: https://grow.liferay.com/excellence/Liferay+Outbound+Licensing+Policy Did this by updating `copyright.js` and running `yarn lint:fix`. I used a Vim macro to strip out the original headers. Note some files required manual fixing because they had ESLint or other comments at the top of the file (this is bad; the header should always be at the top). Some of the comments I could just remove (eg. unnecessary lint suppressions), but the others I moved below the header. Adds a copy of the license to `LICENSES/MIT.txt` as required by the policy too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is analogous to the one I just made in:
liferay/eslint-config-liferay#151
It updates the license header format to match the latest policy:
https://grow.liferay.com/excellence/Liferay+Outbound+Licensing+Policy
Did this by updating
copyright.js, runningyarn lint:fix, and then applying manual fixes to the threebinfiles (because of their use of "shebang" lines, the linter adds a redundant copy of the header). I used a Vim macro to reset the year to its original value (2019) instead of letting the linter update it to 2020.