This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
Now onScroll uses debounce on saveHistory #233
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When CI run my tests on #232, it catches some errors that being shown below:
I've noticed that
replaceState
security error is caused by spamming scroll event when updating history state. Using debounce we can reduce the occurrence ofreplaceState
event and solve this Security Error.