refactor(solana)!: upgrade from web3.js to solana kit #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
tomiiide
changed the title
tomiiide
requested review from
chybisov and
effie-ms
and removed request for
chybisov
effie-ms
reviewed
Nov 19, 2025
effie-ms
reviewed
Nov 19, 2025
effie-ms
reviewed
Nov 19, 2025
packages/sdk-provider-solana/src/utils/KeypairWallet.unit.spec.ts
Outdated
Show resolved
Hide resolved
effie-ms
reviewed
Nov 19, 2025
packages/sdk-provider-solana/src/utils/KeypairWallet.unit.spec.ts
Outdated
Show resolved
Hide resolved
effie-ms
reviewed
Nov 19, 2025
packages/sdk-provider-solana/src/utils/KeypairWallet.unit.spec.ts
Outdated
Show resolved
Hide resolved
effie-ms
reviewed
Nov 19, 2025
packages/sdk-provider-solana/src/utils/KeypairWallet.unit.spec.ts
Outdated
Show resolved
Hide resolved
tomiiide
commented
Nov 21, 2025
tomiiide
commented
Nov 21, 2025
packages/sdk-provider-solana/src/utils/KeypairWallet.unit.spec.ts
Outdated
Show resolved
Hide resolved
tomiiide
commented
Nov 21, 2025
packages/sdk-provider-solana/src/utils/KeypairWallet.int.spec.ts
Outdated
Show resolved
Hide resolved
effie-ms
reviewed
Nov 21, 2025
Member
|
@tomiiide could you please rebase and make the PR only about Solana Kit changes 🙏 It would be hard to review 273 files again 😅 |
Contributor
Author
chybisov
requested changes
Dec 3, 2025
packages/sdk-provider-solana/src/actions/sendAndConfirmTransaction.ts
Outdated
Show resolved
Hide resolved
2 tasks
tomiiide
force-pushed
the
LF-13181-upgrade-v4-to-solana-kit
branch
from
658e4d8 to
50b978a
Compare
tomiiide
changed the title
tomiiide
force-pushed
the
LF-13181-upgrade-v4-to-solana-kit
branch
2 times, most recently
from
b22d296 to
c8eb74d
Compare
- Replace legacy @solana/web3.js v1.x and wallet-adapter packages with unified @solana/kit v5 SDK. - Remove isSolanaAddress (use toAddress export instead) - Remove KeypairWalletName export
tomiiide
force-pushed
the
LF-13181-upgrade-v4-to-solana-kit
branch
from
c8eb74d to
bf171b2
Compare
tomiiide
changed the title
effie-ms
reviewed
Dec 30, 2025
effie-ms
reviewed
Dec 30, 2025
effie-ms
reviewed
Dec 30, 2025
effie-ms
reviewed
Dec 30, 2025
- check if rpc connections exists before creation
tomiiide
force-pushed
the
LF-13181-upgrade-v4-to-solana-kit
branch
from
4779716 to
d7355e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira task is linked to this PR?
https://lifi.atlassian.net/browse/LF-13181
Why was it implemented this way?
Explain the reasoning behind the implementation. Were there alternative approaches? Why was this solution chosen?
The solana provider
@solana/web.jslibrary for the new@solana/kit@solana/wallet-adapter-baseto the new@wallet-standard/wallet-standard.Breaking changes
getWalletAdapterconfig option is renamed togetWalletVisual showcase (Screenshots or Videos)
If applicable, attach screenshots, GIFs, or videos to showcase the functionality, UI changes, or bug fixes.
Checklist before requesting a review