Merge pull request #518 from lifion/bugfix/update-eslint-rules-and-fi…

…x-tests Bugfix/update eslint rules and fix tests
lifion · Dec 13, 2021 · 6fb394b · 6fb394b
2 parents 96b0f13 + b645d86
commit 6fb394b
Show file tree

Hide file tree

Showing 11 changed files with 100 additions and 93 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -4,7 +4,23 @@
     "jest/no-conditional-expect": "off",
     "radar/no-identical-functions": "off",
     "unicorn/no-array-callback-reference": "off",
-    "unicorn/no-array-for-each": "off"
+    "unicorn/no-array-for-each": "off",
+    "unicorn/prefer-object-from-entries": "off",
+    "no-secrets/no-secrets": ["error", {
+      "ignoreContent": [
+        "NoSuchLifecycleConfiguration",
+        "Kinesis_20131202.SubscribeToShard",
+        "ProvisionedThroughputExceededException",
+        "InvalidArgumentException",
+        "SubscribeToShardEvent",
+        "params.provisionedThroughput.writeCapacityUnits",
+        "eyJmb28iOiJiYXIsIGJhesQFxgoifQ==",
+        "Qk2rZuty0pO/vptdjx3KZ2hUqVM=",
+        "n0vR6WyiMI1VeNqoISbuIEPoMPM=",
+        "hoKe98qHWTKVJg\\+g8IEsdvvnrLI=",
+        "uM9dgBWF4OGL42Uqbr61Yyt5h58="
+      ]
+    }]
   },
   "overrides": [
     {

diff --git a/README.md b/README.md
diff --git a/lib/dynamodb-client.js b/lib/dynamodb-client.js
@@ -43,7 +43,6 @@ function internal(instance) {
  * @reject {Error} - The error details from AWS.DynamoDB with a corrected error stack.
  * @returns {Promise}
  * @private
- *
  */
 async function sdkCall(client, methodName, ...args) {
   const stackObj = getStackObj(sdkCall);

diff --git a/lib/fan-out-consumer.test.js b/lib/fan-out-consumer.test.js
@@ -49,7 +49,7 @@ jest.mock('./stream', () => ({
 
 jest.mock('./stats');
 
-jest.useFakeTimers();
+jest.useFakeTimers('legacy');
 
 function nextTickWait() {
   return new Promise((resolve) => setImmediate(resolve));
@@ -108,7 +108,7 @@ describe('lib/fan-out-consumer', () => {
     clearTimeout.mockReset();
     setTimeout.mockReset();
     jest.clearAllTimers();
-    jest.useFakeTimers();
+    jest.useFakeTimers('legacy');
   });
 
   test('the module exports the expected', () => {

diff --git a/lib/heartbeat-manager.test.js b/lib/heartbeat-manager.test.js
@@ -15,7 +15,7 @@ describe('lib/heartbeat-manager', () => {
   const stateStore = { clearOldConsumers, registerConsumer };
 
   beforeEach(() => {
-    jest.useFakeTimers();
+    jest.useFakeTimers('legacy');
   });
 
   afterEach(() => {

diff --git a/lib/index.test.js b/lib/index.test.js
@@ -128,7 +128,7 @@ jest.mock('./stream', () => {
   };
 });
 
-jest.useFakeTimers();
+jest.useFakeTimers('legacy');
 
 describe('lib/index', () => {
   const options = { compression: 'LZ-UTF8', streamName: 'test-stream' };

diff --git a/lib/lease-manager.test.js b/lib/lease-manager.test.js
@@ -8,7 +8,7 @@ jest.mock('./stream', () => ({
   getStreamShards: jest.fn(() => Promise.resolve({}))
 }));
 
-jest.useFakeTimers();
+jest.useFakeTimers('legacy');
 
 describe('lib/lease-manager', () => {
   const reconcile = jest.fn();

diff --git a/lib/polling-consumer.test.js b/lib/polling-consumer.test.js
@@ -9,7 +9,7 @@ jest.mock('./stream', () => ({
   getStreamShards: () => Promise.resolve({ 'shard-0000': {} })
 }));
 
-jest.useFakeTimers();
+jest.useFakeTimers('legacy');
 
 describe('lib/polling-consumer', () => {
   const getRecords = jest.fn(() =>

diff --git a/lib/s3-client.js b/lib/s3-client.js
@@ -43,7 +43,6 @@ function internal(instance) {
  * @reject {Error} - The error details from AWS.S3 with a corrected error stack.
  * @returns {Promise}
  * @private
- *
  */
 async function sdkCall(client, methodName, ...args) {
   const stackObj = getStackObj(sdkCall);

diff --git a/lib/stats.test.js b/lib/stats.test.js
@@ -4,7 +4,7 @@
 
 const { version } = require('../package.json');
 
-jest.useFakeTimers();
+jest.useFakeTimers('legacy');
 
 describe('lib/stats', () => {
   let getStats;

diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
   "homepage": "https://github.com/lifion/lifion-kinesis#readme",
   "main": "lib/index.js",
   "engines": {
-    "node": ">=10.0.0"
+    "node": ">=10.0.0 <16.10.0 || >16.13.0 <17.0.0 || >=17.0.1"
   },
   "scripts": {
     "build-docs": "jsdoc2md -t ./templates/README.hbs ./lib/*.js > ./README.md && git add ./README.md",