Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds changes per webauthn audit #42

Merged
merged 4 commits into from
Jun 22, 2022
Merged

adds changes per webauthn audit #42

merged 4 commits into from
Jun 22, 2022

Conversation

tt0mmy
Copy link
Contributor

@tt0mmy tt0mmy commented Jun 21, 2022 •
edited
Loading

Description

  • challenge is now random bytes
  • validates challenge when creating public key
  • adds webauthn compatibility check

Related Issues

Fixes #47
Fixes #48

Testing

  • update tests to include nonce

Checklist:

  • I have read and followed the CONTRIBUTING guidelines for this project.
  • I have added or updated tests and they pass.

@tt0mmy tt0mmy requested a review from hansl June 21, 2022 20:52
@tt0mmy tt0mmy merged commit 0f9c90c into liftedinit:main Jun 22, 2022
@tt0mmy tt0mmy deleted the webauthn-audit branch June 22, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansl hansl hansl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tt0mmy @hansl