Let user specify path to sleigh compiler in CMake module #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows user to specify an arbitrary sleigh compiler. Almost always it's going to be the sleigh::sleigh_opt target, but in the case of cross-compiling, that won't work because the host won't be able to run it.
ekilmer
force-pushed
the
specify-sleigh-compiler
branch
from
ddf48d4 to
3c3ad5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows user to specify an arbitrary sleigh compiler. Almost always
it's going to be the sleigh::sleigh_opt target, but in the case of
cross-compiling, that won't work because the host won't be able to run
it.
This should enable fixing trailofbits/maat#64. Will wait until it's confirmed that this fixes that issue before merging.
This change is also backwards-incompatible with existing code that uses the function, so it will deserve a (package) version bump.