replace supervisord with vpp-agent-init #1318

VladoLavor · 2019-05-06T06:39:04Z

Signed-off-by: Vladimir Lavor vlavor@cisco.com

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

docker/dev/init_hook.sh

ondrej-fabry · 2019-05-28T09:00:18Z

docker/dev/init_hook.sh

@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+


Script is missing old functionality provided by RETAIN_SUPERVISOR variable.

True, however, hook scripts are started in a dedicated environment so RETAIN_SUPERIVSOR set to the docker environment would not be passed to the script anyway. We would need it supported in the supervisor plugin I guess.

But we can live without it now, didn't we? The hook script takes care of the termination of the init. Remove the hook from the supervisor.conf and we have basically the same functionality the RETAIN_SUPERVISOR provides. What do you think?

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

ondrej-fabry · 2019-05-30T06:59:10Z

docker/dev/supervisor.conf

+  - name: "vpp"
+    executable-path: "/usr/bin/vpp"
+    executable-args: ["-c", "/etc/vpp/vpp.conf"]
+    logfile-path: "/var/log/supervisord.log"


This is not correct log file path for vpp.

The log file path can be whatever you want, so I don't think there is some "correct" setup. Also, it's the same path we have set before (just for reference, I agree to remove it as stated below)

You might be confusing log of supervisord process:

vpp-agent/docker/dev/supervisord.conf

Line 2 in 80401e6

logfile=/var/log/supervisord.log

The output of both VPP and Agent were printed through supervisord stdout/stderr.

ondrej-fabry · 2019-05-30T07:00:19Z

docker/dev/supervisor.conf

+  - name: "agent"
+    executable-path: "/go/bin/vpp-agent"
+    executable-args: ["--config-dir=/opt/vpp-agent/dev"]
+    logfile-path: "/var/log/supervisord.log"


Neither is this one. I don't think logfile paths should be set at all. We want to have log output coming from vpp-agent-init's stdout/stderr, just like it was working previously.

Previously we had both, a log file and stdout/stderr. Let's stay only with the latter.

We actually did not:

vpp-agent/docker/dev/supervisord.conf

Lines 7 to 18 in 80401e6

[program:vpp]

command=/usr/bin/exec_vpp.sh

autorestart=false

redirect_stderr=true

priority=1

[program:agent]

command=/usr/bin/exec_agent.sh

startsecs=0

autorestart=false

redirect_stderr=true

priority=2

I see, the log file set was only for the supervisory process

The confusion might be because the /var/log/supervisord.log file contained output coming from redirected stdout/stderr.

ondrej-fabry · 2019-05-30T07:03:59Z

vendor/github.com/ligato/cn-infra/exec/supervisor/plugin.go

+// Close local resources
+func (p *Plugin) Close() error {
+	for _, program := range p.programs {
+		if err := program.svLogger.Close(); err != nil {


This will actually close loggers before even trying to stop programs.

ondrej-fabry · 2019-05-30T07:04:51Z

vendor/github.com/ligato/cn-infra/exec/supervisor/plugin.go

+			p.Log.Errorf("failed to close logger: %v", err)
+		}
+	}
+	close(p.hookChan)


The hookChan channel is closed by non-producer goroutine and might actually cause when watch tries to send event to it.

ondrej-fabry · 2019-05-30T07:05:34Z

vendor/github.com/ligato/cn-infra/exec/supervisor/plugin.go

+		}
+	}
+	close(p.hookChan)
+	return nil


The Close method should stop running programs and wait until all programs have exited.

ondrej-fabry · 2019-05-30T07:14:48Z

cmd/vpp-agent-init/main.go

+)
+
+func main() {
+	a := agent.NewAgent(agent.AllPlugins(sv.NewPlugin()))


This should rather use DefaultPlugin instance.

If you like it better that way :-)

It's not about liking, but about avoiding this log message:

DEBU[0000] using plugin logger for "supervisor" that was already initialized loc="logging/log_api.go(226)" logger=defaultLogger

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor · 2019-05-30T07:46:50Z

Marked as WIP till the CN-Infra part is not resolved.

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

* Update NAT example for VPP 19.04. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Remove unused dep from Gopkg.toml Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Install vpp-plugin-dpdk package Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Install python3-cffi package (dependency for python3-vpp-api) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Rework RxPlacement and RxMode to allow per-queue configuration Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Fix build. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * remove tapv1 test and fix tests (#1339) Signed-off-by: AndrejKilvady <andrej.kilvady@pantheon.tech> * Use arrays instead of maps for RxMode and placement. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Fix for SRv6 localsid delete in nonzero vrf tables (#1338) Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech> * fix robot test (#1340) Signed-off-by: AndrejKilvady <andrej.kilvady@pantheon.tech> * Add etcd ansible python plugin (#1336) * Add etcd ansible python plugin * Add example ansible playbook * Fix indentation * Update example playbook Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Fix stats publishers (#1341) * Fix *-ifplugin config names * Unset default stats publishers used as fallback without config Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Define datasyncs used for setting publishers from config or env Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add dependency on link-state for rx placement and rx mode. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Update and add UTs for rx placement and rx mode Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Adapter for rx mode descriptor Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Update GoVPP (#1342) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Bug fixing txn post-processing in kvscheduler. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Add example for rx-placement and rx-mode. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Pluralize rx-mode and rx-placement Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Add check for multiple descriptors matching the same key. Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Pluralize also key for all rx-modes of an interface Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Remove unnecessary LinkIsUp from interface metadata Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Refactor image building to use ligato/vpp-base (#1343) * Refactor image builds to use ligato/vpp-base Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fixed automatic launching of SRv6 crud robot tests (#1346) Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech> * remove agent-ctl and kafka (#1345) Signed-off-by: AndrejKilvady <andrej.kilvady@pantheon.tech> * Define env vars for overriding start/stop timeouts of agent Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Support building images with different VPP versions (#1348) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Pass image_tag Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix installing deb packages for VPP 19.01 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * DHCP proxy for VPP (#1349) * Add DHCP proxy plugin initial commit Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Fix nil dump Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update dhcp_proxy.go Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update plugin fix namings add validate and dependecy implementation fix validation in write new dhcp proxy Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Change isIPv6 to 0 if IPv4 Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update dump function Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update Ip formatting Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Fix older version Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Add DHCPv6 support Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Fix bugs, clean up Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Clean up and update validate implementation Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Add messages to handler Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update error message Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * remove unused ipToAddress Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update error message Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update validate implementation Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Update error message Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> * Regenerate proto files Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix travis errors Signed-off-by: miroslav.kovac <miroslav.kovac@pantheon.tech> Co-authored-by: Ondrej Fabry <ofabry@cisco.com> * Fix caching for building docker images Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Make channel for notifications buffered (#1352) Even though notifications are processed quickly in separate go routines, it still may not be enough if multiple of them are received at roughly the same time, causing potential drops. Added small buffer for the notification channel. * Remove default for agent version and add grpc perf to dockerignore Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add interfaces metrics to telemetry plugin (#1351) * Add interface metrics to telemetry plugin * Change telemetry URL for prometheus export to `/metrics/vpp` * Cleanup metric names * Rename node count to counter Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix IPv6 detection (#1355) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * add ABF to config data model (#1356) Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Improve error logs for invalid key value pairs (#1359) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Minor Code Fixes (#1361) * fix panic if model is registered without name * fix key variable shadowed * Allow disabling interface stats reading Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * replace supervisord with vpp-agent-init (#1318) * update cn-infra dep * add vpp-agent-init * fix deps * remove logfile paths from supervisor conf * update to latest supervisor Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Allow skipping binapi check in dev docker image Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * fix crash for iptables rulechain with default microservice Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Support for VPP 19.08-rc0 (#1357) * Add preliminary support for VPP 19.08 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * updated govppmux to 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * updated abf and acl plugins to 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * updated ifplugin and ipsec plugin to 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * update l2 and l3 plugin to 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * updated nat and punt plugins to 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * update sr and stn plugin to 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * regenerate binapi for ip, nat and session Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * improvements Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * telemetry 1908 Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Update VPP images Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix VPP version in vppcalls handlers Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add config status publishing for config items (#1364) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add some (temporary) debug logs for interface state updates (#1367) Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * vpp updated to v19.08-rc0.324-g2ecf18a55 (#1366) * update govpp * update vpp to v19.08-rc0~324-g2ecf18a55 * update vppcalls * update punt tests Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Update CHANGELOG for v2.1.1 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update README.md * add rest support for ipsec and punt (#1368) * remove nul chars from retrieved punt socket path * add rest support for ipsec and punt Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Fix init order of state channel (#1369) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * initialize abf plugin handler in configurator (#1371) Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Add env var (RESYNC_TIMEOUT) for setting resync timeout (#1372) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Minor enhancements in Linux interface descriptor (#1374) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * tweaked interface statistics Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * wip Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Revert "wip" This reverts commit e993d3b. * Revert "tweaked interface statistics" This reverts commit 8715c96. * Retrieve cmdline (config) after conencting to VPP (#1381) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * fix punt dump for all vpp versions (#1379) * fix dump punt log * fix punt dump for all vpp versions Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Fix dumps for unavailable handlers - do not return error for dumps when some handlers are not available - log all unavailable handlers during initialization of restapi/configurator - remove unused dump channels from vppcalls Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Revert "fix punt dump for all vpp versions" (#1385) This reverts commit 36636ab. * Remove unused dump channel Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * vpp.punt: Add support for punt exceptions (#1384) * Add support for punt exceptions - added support for punt exceptions in puntplugin - fixed deleting of registered sockets after resync - forcing recreation of registered sockets using prefix '!' in socket path - SetPunt is not used anymore Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update documentation for VPP Punt API Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add punt exceptions to clientv2 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add fixes for punt plugin (#1389) - do not check socket path for punt exceptions to prevent recreation - add depenency for RX interface to ip redirect punt - implement IP redirect dump (only for 19.08) - add workaround for publishing socket to punt exceptions as well - properly deregister punt exeption on delete - return pathname from registration when adding punt exception - add workaround with ! prefix to punt exceptions - publish socket paths to status with client TTL Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update VPP 19.08 (#1394) * update to vpp v19.08-rc0~432-gb63dbc537 (#1390) Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * Update GoVPP and vpp.env Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix nil stats in telemetry Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Regenerate binapi for VPP 19.04 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * fix IPSec security associations tunnel mode (#1395) Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * fix building of docker images for ARM64 (make images) (#1376) * agentctl: Add import command for importing config from file Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * agentctl: Fix import of full keys Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * agentctl: Add flag to set number of ops per transaction Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * agentctl: Add gRPC support to import command Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Move debugging into debug package (#1397) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * govppmux stats REST handler (#1396) * Add govppmux stats handler for REST and improve stats Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Allow disabling status publishing and interface stats collection Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * agentctl: Remove unused type Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update README.md (#1400) * Performance improvements around isNodeReady (#1402) * Add some (temporary) debug logs for interface state updates Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Performance improvements around isNodeReady Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Update GoVPP and use pure Go client adapters by default (#1401) * Update GoVPP and use pure Go client adapters by default Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update GoVPP with fix for duplicate objects Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add derived (property) key-value marking interface with at leas… (#1403) Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Update perf tests (#1404) * Update perf test Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update perf test Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update perf test Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Cleanup puntplugin (#1405) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * vpp19.08 updated to rc0.581-g3eea9de89 (#1407) * update abf plugin * update interface plugin * update l2 plugin * update L3 plugin * removed redundant log * code improvements and cleanup * added support for VRF index map * l3 plugin dumps ipv4 and ipv6 routes * add vrf proto to metadata Signed-off-by: Vladimir Lavor <vlavor@cisco.com> * VPP integration tests (#1409) * Add initial vpp integration test Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Test integration tests on travis Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Skip integration tests on travis Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update vpp integration tests Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Set govpp logger level on debug Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add integration test for interface Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Run integration tests and verify binapi for each VPP version in travis Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix env matrix Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Try fix env Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Try travis fix Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add README for vpp integration tests Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Clean stages Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix stages Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add go_import_path back Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Regenerate binapi for VPP 19.01 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update Go in docker Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add abf patch to VPP 1901 binapi Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix binapi patches for VPP 19.08 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix binapi patches for VPP 19.08 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update GoVPP & aggregated watcher (#1410) * Update GoVPP Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add aggregated watcher from vpp1908 branch Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix key collisions for vpp routes (#1411) * Add outgoing interface to route key Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add unit tests for vpp route key Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * added memif interface test to tests/integration (#1412) Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * Update VPP to 19.08-rc0.666-g9082b43dd (#1413) * Update VPP to 19.08-rc0.666-g9082b43dd Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update VPP to 19.08-rc0.673-ga2e4451db Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix in Telemetry plugin and improvements for integration tests (#1414) * Add DumpInterface to vppcalls in ifplugin Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Cleanup vpp integration tests Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix file name Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Hide iptables warning when no config found Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Print shm warning directly into stderr Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix single interface dump for older VPP Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix retrieving memory stats in telemetry for VPP 19.08 Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add tests for telemetry to VPP integration tests Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix integration tests - Skip some telemetry integration tests for VPP<=19.04 - Fix GetMemory in telemetry for VPP<=19.04 - Use hard-coded config for VPP - Use DOCKER_ARGS for custom arguments for docker Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update GoVPP Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix URL for VPP metrics in telemetry plugin (#1416) * Fix URL for VPP metrics in telemetry plugin Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update Gopkg.lock * Optimize interface state dump for specific interfaces (#1415) * Optimize interface state dump for specific interfaces - define env var for printing debug logs about interface states - extend interface state info in vppcalls for ifplugin - return error when loading config fails - minor improvements for VPP integration testing Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Remove obsolete function Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add option for skipping metrics in telemetry plugin (#1417) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Added CRUD integration tests for IPv4/IPv6 (#1419) * Added CRUD integration tests for IPv4/IPv6 routes in default VRF and VRF=2 Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * improving code Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * removed comments and parametrized value of VRF (vrfMetaIdx) * removed redundant initialisation to default value causes warnings in travis Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * Minor enhancements and code cleanups (#1420) * Minor enhancement for transaction summary log Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add make target for remote debugging with delve Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Minor code cleanup in vpp ifplugin Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Fix error check when renaming tap and cleanup code Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Add integration test for IP address (#1421) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * added arp crud integration test (#1422) * added arp crud integration test Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * comments removed * added more asserts - asserts related to number of arp entries in arp dump - asserting of fields of arp entry - assert non presence in arp dump - hard-coded index replaced by generated one stored in the variable ifIdx Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * simplify assert (omitting assert of Static field) Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * Update VPP to 19.08-rc0.699-gf7c30df4b (#1424) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * kvscheduler: keep node in the graph during recreate (#1423) This patch fixes issues reported in #1418. During recreate (Delete+Create) the node would be completely removed from the graph by Delete and all the associated flags (metadata) were therefore lost. When the subsequent Create fails, the scheduler needs to access the flags, which in this case are undefined, causing the scheduler to panic by dereferencing nil pointer. This patch ensures that the node and its flags are preserved during re-creation. An in-progress refactor of the scheduling algorithm will approach value recreation in a much cleaner way... Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech> * Update VPP to 19.08-rc0.706-ga58fec168 (#1426) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Define VRF as retrieve dependency for routes (#1429) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * extend linux plugin (#1431) * add "EXISTING" interface type Signed-off-by: Matus Mrekaj <matus.mrekaj@pantheon.tech> * update interface descriptor Signed-off-by: Matus Mrekaj <matus.mrekaj@pantheon.tech> * update interface descriptor Signed-off-by: Matus Mrekaj <matus.mrekaj@pantheon.tech> * WIP integration test ACL IP CRUD (#1428) * integration test ACL IP rule CRUD Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * renamed to 040_acl_test.go Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * to satisfy lint Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * Trying to loop over acl dump * Looping over IP rule * acl IP rule CRUD almost finished Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * acl IP rule CRUD Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * satisfy lint * added acl integration test for MAC IP rules fixed comments in interface definition Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * fix comments - they should start with space Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * create a helper function that returns ACL rule - for IP rule - for IP MAC rule Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * acl integration test - refactoring - introducing of helper functions to eliminate declaration of acl_rule variables - removing needless convert with uint32 - simplifying code with expect functions - improving logged messages to improve understanding Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * satisfy lint Signed-off-by: Stanislav Chlebec <stanislav.chlebec@pantheon.tech> * Fix Retrieve for TAPv2 interface without Linux-side NB config (#1432) Signed-off-by: Milan Lenco <milenco@cisco.com> * Update VPP 19.08 to stable (rc1) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Update VPP 19.08 to stable (rc1) (#1433) Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Release v2.2.0-beta Signed-off-by: Ondrej Fabry <ofabry@cisco.com> * Changelog for vpp-agent v2.2.0-beta Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor added 🔧 enhancement 🚧 WIP do not merge! work in progress! labels May 6, 2019

VladoLavor self-assigned this May 6, 2019

VladoLavor force-pushed the init branch from 82fdf0e to 9827488 Compare May 7, 2019 10:11

VladoLavor requested a review from ondrej-fabry May 7, 2019 10:12

ondrej-fabry added this to the v2.2.0 milestone May 9, 2019

update cn-infra dep

c7890f3

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor force-pushed the init branch 2 times, most recently from 62cc52d to a817047 Compare May 28, 2019 07:47

VladoLavor marked this pull request as ready for review May 28, 2019 07:48

VladoLavor removed the 🚧 WIP do not merge! work in progress! label May 28, 2019

ondrej-fabry reviewed May 28, 2019

View reviewed changes

docker/dev/init_hook.sh Show resolved Hide resolved

ondrej-fabry reviewed May 28, 2019

View reviewed changes

VladoLavor force-pushed the init branch 2 times, most recently from b555d63 to 7799c88 Compare May 29, 2019 14:12

add vpp-agent-init

6c393b0

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor force-pushed the init branch from 7799c88 to 6c393b0 Compare May 29, 2019 14:13

fix deps

2aea15b

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor requested a review from ondrej-fabry May 29, 2019 14:34

ondrej-fabry reviewed May 30, 2019

View reviewed changes

remove logfile paths from supervisor conf

7eedf1f

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor added the 🚧 WIP do not merge! work in progress! label May 30, 2019

ondrej-fabry mentioned this pull request May 30, 2019

supervisor terminates programs before closing ligato/cn-infra#396

Merged

update to latest supervisor

dbb52fc

Signed-off-by: Vladimir Lavor <vlavor@cisco.com>

VladoLavor removed the 🚧 WIP do not merge! work in progress! label May 30, 2019

VladoLavor requested a review from ondrej-fabry May 30, 2019 13:17

ondrej-fabry approved these changes May 31, 2019

View reviewed changes

ondrej-fabry merged commit bd34af0 into ligato:dev May 31, 2019

VladoLavor deleted the init branch June 3, 2019 11:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace supervisord with vpp-agent-init #1318

replace supervisord with vpp-agent-init #1318

VladoLavor commented May 6, 2019

ondrej-fabry May 28, 2019

VladoLavor May 28, 2019

ondrej-fabry May 30, 2019

VladoLavor May 30, 2019

ondrej-fabry May 30, 2019

ondrej-fabry May 30, 2019 •

edited

Loading

VladoLavor May 30, 2019

ondrej-fabry May 30, 2019

VladoLavor May 30, 2019

ondrej-fabry May 30, 2019

ondrej-fabry May 30, 2019

ondrej-fabry May 30, 2019

ondrej-fabry May 30, 2019

ondrej-fabry May 30, 2019

VladoLavor May 30, 2019

ondrej-fabry May 30, 2019 •

edited

Loading

VladoLavor commented May 30, 2019

	[program:vpp]
	command=/usr/bin/exec_vpp.sh
	autorestart=false
	redirect_stderr=true
	priority=1

	[program:agent]
	command=/usr/bin/exec_agent.sh
	startsecs=0
	autorestart=false
	redirect_stderr=true
	priority=2

replace supervisord with vpp-agent-init #1318

replace supervisord with vpp-agent-init #1318

Conversation

VladoLavor commented May 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ondrej-fabry May 30, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ondrej-fabry May 30, 2019 • edited Loading

Choose a reason for hiding this comment

VladoLavor commented May 30, 2019

ondrej-fabry May 30, 2019 •

edited

Loading

ondrej-fabry May 30, 2019 •

edited

Loading