Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for SPAN feature #1468

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Conversation

rewenset
Copy link
Contributor

No description provided.

@rewenset rewenset added the 🚧 WIP do not merge! work in progress! label Sep 12, 2019
@rewenset rewenset changed the title WIP: Add e2e test for SPAN feature Add e2e test for SPAN feature Sep 13, 2019
@rewenset rewenset removed the 🚧 WIP do not merge! work in progress! label Sep 13, 2019
Copy link
Collaborator

@milanlenco milanlenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one suggestion to limit code repetition it looks good.

tests/e2e/030_span_test.go Outdated Show resolved Hide resolved
tests/e2e/e2e_test.go Outdated Show resolved Hide resolved
@ondrej-fabry ondrej-fabry merged commit be29593 into ligato:dev Sep 25, 2019
VladoLavor pushed a commit to VladoLavor/vpp-agent that referenced this pull request Oct 4, 2019
* Add e2e test for SPAN feature

* Comments and a little optimization

* Create method for executing vppctl commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants