Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Agentctl enhancements #1474

Merged
merged 13 commits into from
Sep 30, 2019
Merged

refactor: Agentctl enhancements #1474

merged 13 commits into from
Sep 30, 2019

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Sep 20, 2019 •
edited
Loading

  • agentctl code was refactored and split into several packages:
    • cli - generic CLI apps API
    • client - vpp-agent client API
    • api/api/types - types used by clients
    • commands - agentctl base commands

@ondrej-fabry ondrej-fabry added the 🚧 WIP do not merge! work in progress! label Sep 20, 2019
@ondrej-fabry ondrej-fabry changed the title WIP: Agentctl enhancements feat: Agentctl enhancements Sep 26, 2019
golangcibot
golangcibot reviewed Sep 26, 2019
View reviewed changes
cmd/agentctl/cli/cli.go Outdated Show resolved Hide resolved
cmd/agentctl/client/client.go Outdated Show resolved Hide resolved
cmd/agentctl/client/http.go Outdated Show resolved Hide resolved
cmd/agentctl/commands/root.go Outdated Show resolved Hide resolved
cmd/agentctl/client/http.go Outdated Show resolved Hide resolved
cmd/agentctl/client/client.go Outdated Show resolved Hide resolved
cmd/agentctl/client/infra.go Outdated Show resolved Hide resolved
cmd/agentctl/client/http.go Outdated Show resolved Hide resolved
cmd/agentctl/client/http.go Outdated Show resolved Hide resolved
cmd/agentctl/client/http.go Outdated Show resolved Hide resolved
@ondrej-fabry ondrej-fabry added 🔧 enhancement and removed 🚧 WIP do not merge! work in progress! labels Sep 26, 2019
@ondrej-fabry ondrej-fabry changed the title feat: Agentctl enhancements refactor: Agentctl enhancements Sep 26, 2019
@VladoLavor VladoLavor self-requested a review September 27, 2019 12:35
@ondrej-fabry
Fix doc comment for agentctl
fbece6c 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Use defined name in usage line
0e67055 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Fix http client
c688bba 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Refactor agentctl
00eddb9 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Fix problems reported by golangcibot
6ade436 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Cleanup client options
c138179 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Define KVDBAPIClient
4607e7d 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Cleanup code
13dad98 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Resolve comments
1c765bf 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Resolve comments
3b5d08d 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Fix response
fdfd17d 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Resolve review comments
222d179 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Remove unused model list option
8a72f4c 
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry self-assigned this Sep 30, 2019
@ondrej-fabry ondrej-fabry merged commit b90bddd into ligato:dev Sep 30, 2019
@ondrej-fabry ondrej-fabry deleted the agentctl branch September 30, 2019 10:57
VladoLavor pushed a commit to VladoLavor/vpp-agent that referenced this pull request Oct 4, 2019
@ondrej-fabry @VladoLavor
refactor: Agentctl enhancements (ligato#1474)
9a195a0 
* Fix doc comment for agentctl

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Use defined name in usage line

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Fix http client

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Refactor agentctl

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Fix problems reported by golangcibot

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Cleanup client options

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Define KVDBAPIClient

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Cleanup code

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Resolve comments

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Resolve comments

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Fix response

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Resolve review comments

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>

* Remove unused model list option

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@rewenset rewenset rewenset left review comments

@VladoLavor VladoLavor VladoLavor approved these changes

Assignees

@ondrej-fabry ondrej-fabry

Labels
🔧 enhancement ♻️ refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ondrej-fabry @VladoLavor @rewenset @golangcibot