test: Code coverage for e2e tests #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a coverage of all e2e tests: EDIT: Also, for example, test and as for test Also I'm able to generate html file, but not sure how to share it :) |
What are those numbers on the right? Is it really counting all packages? |
|
I'm using gocov for coverage analysis.
Packages coverage after running all E2E tests
I've removed all Or coverage of registry package from internal of kvscheduler plugin
|
rewenset
force-pushed
the
e2e-coverage
branch
from
484f335
to
18e08e9
Compare
rewenset
changed the title
rewenset
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1475 +/- ##
======================================
Coverage ? 52.12%
======================================
Files ? 544
Lines ? 65827
Branches ? 0
======================================
Hits ? 34314
Misses ? 29274
Partials ? 2239
Continue to review full report at Codecov.
|
test-e2e
rewenset
force-pushed
the
e2e-coverage
branch
from
64e36f9
to
29c7ddb
Compare
rewenset
changed the title
|
upload unittests coverage to coveralls was intentionally left there. I think that it would be better to remove it after some time with codecov |
milanlenco
approved these changes
Oct 2, 2019
test-e2e
ondrej-fabry
approved these changes
Oct 6, 2019
VladoLavor
pushed a commit
to VladoLavor/vpp-agent
that referenced
this pull request
Oct 18, 2019
* Initial collecting coverage for e2e tests * Allow to run e2e tests with and without coverage * Add build tag to dummy test, so it is skipped in general case * Upload coverage to codecov test-e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a dummy test that executes
main()ofvpp-agent. Each e2e test starts that executable with enabled coverage analysis. All coverage data will be stored in/tmp/e2e-coveragedirectory and after merged with gocovmerge to one/tmp/e2e-all.outfile.The idea of how coverage could be collected was borrowed from "Go coverage with external tests".