Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Agent services, refactor generic models #1494

Merged
merged 27 commits into from
Oct 11, 2019

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Oct 3, 2019

  • switch from gogo to official proto package: github.com/golang/protobuf
  • register grpc server for reflection
  • add service subcommand to agentctl
  • add service list command for listing services/methods
  • add service call command for calling services
  • add metrics list command
  • add metrics get command
  • add Class to model spec
  • rename genericmanager to generic
  • add generic.MetaService for managing models

@ondrej-fabry ondrej-fabry added ⚡️ feature 🚧 WIP do not merge! work in progress! labels Oct 3, 2019
@ondrej-fabry ondrej-fabry changed the title [WIP] feat: Switch to official proto package (deprecating gogo) [WIP] feat: Agent services Oct 4, 2019
@ondrej-fabry ondrej-fabry changed the title [WIP] feat: Agent services feat: Agent services [WIP] Oct 4, 2019
@codecov
Copy link

codecov bot commented Oct 9, 2019

Codecov Report

Merging #1494 into dev will increase coverage by 4.09%.
The diff coverage is 32.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1494      +/-   ##
==========================================
+ Coverage   51.15%   55.25%   +4.09%     
==========================================
  Files         631      346     -285     
  Lines       78204    29938   -48266     
==========================================
- Hits        40008    16543   -23465     
+ Misses      35768    12103   -23665     
+ Partials     2428     1292    -1136
Flag Coverage Δ
#e2e1904 ?
#e2e1908 ?
#unittests 55.25% <32.43%> (+1.09%) ⬆️

@ondrej-fabry ondrej-fabry changed the title feat: Agent services [WIP] feat: Agent services, refactor generic models Oct 11, 2019
@ondrej-fabry ondrej-fabry removed the 🚧 WIP do not merge! work in progress! label Oct 11, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Copy link
Collaborator

@VladoLavor VladoLavor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are netalloc/interface key files (in models) named z_keys.go?

Otherwise looks good.

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry
Copy link
Member Author

Why are netalloc/interface key files (in models) named z_keys.go?

It was a test with initialization. Will rename back.

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@VladoLavor VladoLavor merged commit 6c970d8 into ligato:dev Oct 11, 2019
@ondrej-fabry ondrej-fabry deleted the agent-services branch October 21, 2019 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants