refactor: Update conf duration to string values #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rewenset
commented
Oct 8, 2019
rewenset
force-pushed
the
conf-duration-str
branch
from
72dcf1c
to
08cb251
Compare
rewenset
force-pushed
the
conf-duration-str
branch
from
08cb251
to
258b6a3
Compare
Codecov Report
@@ Coverage Diff @@
## dev #1505 +/- ##
==========================================
+ Coverage 51.87% 52.85% +0.97%
==========================================
Files 542 277 -265
Lines 64625 25248 -39377
==========================================
- Hits 33527 13345 -20182
+ Misses 28909 10867 -18042
+ Partials 2189 1036 -1153
|
ondrej-fabry
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1503
also updated cn-infra