Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove VAT from xconnect CRUD tests #1507

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

samelias
Copy link
Contributor

@samelias samelias commented Oct 8, 2019

  • rework xconnect CRUD tests to use VPP API instead of VAT
  • code style cleanup of xconnect test suite
  • fix retry loop that verifies xconnect configuration
  • remove IPv6 variant of xconnect CRUD test suite

Signed-off-by: samuel.elias samelias@cisco.com

- rework xconnect CRUD tests to use VPP API instead of VAT
- code style cleanup of xconnect test suite
- fix retry loop that verifies xconnect configuration
- remove IPv6 variant of xconnect CRUD test suite

Signed-off-by: samuel.elias <samelias@cisco.com>
@samelias samelias self-assigned this Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #1507 into dev will increase coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #1507      +/-   ##
=========================================
+ Coverage   51.9%   52.84%   +0.93%     
=========================================
  Files        542      277     -265     
  Lines      64625    25248   -39377     
=========================================
- Hits       33543    13342   -20201     
+ Misses     28899    10869   -18030     
+ Partials    2183     1037    -1146
Flag Coverage Δ
#e2e1904 ?
#e2e1908 ?
#e2e2001 ?
#unittests 52.84% <ø> (-0.02%) ⬇️

@VladoLavor VladoLavor changed the title Test: remove VAT from xconnect CRUD tests test: remove VAT from xconnect CRUD tests Oct 9, 2019
@VladoLavor VladoLavor merged commit a9ab606 into ligato:dev Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants