Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metrics registry #1522

Merged
merged 3 commits into from
Oct 15, 2019
Merged

feat: Add metrics registry #1522

merged 3 commits into from
Oct 15, 2019

Conversation

ondrej-fabry
Copy link
Member

Signed-off-by: Ondrej Fabry ofabry@cisco.com

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@codecov
Copy link

codecov bot commented Oct 15, 2019

Codecov Report

Merging #1522 into dev will increase coverage by 3.65%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1522      +/-   ##
==========================================
+ Coverage   51.55%   55.21%   +3.65%     
==========================================
  Files         637      348     -289     
  Lines       77621    29980   -47641     
==========================================
- Hits        40017    16553   -23464     
+ Misses      35178    12129   -23049     
+ Partials     2426     1298    -1128
Flag Coverage Δ
#e2e1904 ?
#e2e1908 ?
#unittests 55.21% <60%> (-0.05%) ⬇️

pkg/metrics/registry.go Outdated Show resolved Hide resolved
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry merged commit 4dc9dc5 into dev Oct 15, 2019
@ondrej-fabry ondrej-fabry deleted the metrics-registry branch October 15, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants