fix: Allow selectively turn off prometheus metrics and/or stats… #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1532 +/- ##
========================================
+ Coverage 51.7% 55.2% +3.5%
========================================
Files 638 348 -290
Lines 77650 29985 -47665
========================================
- Hits 40147 16554 -23593
+ Misses 35065 12132 -22933
+ Partials 2438 1299 -1139
|
ondrej-fabry
changed the title
ondrej-fabry
requested changes
Oct 21, 2019
There was a problem hiding this comment.
Let's keep Disabled field to avoid breaking existing configs, it should disable entire plugin. Then keep just PrometheusDisabled (remove StatsPollerDisabled) for toggling export for prometheus.
Data from prometheus export should be later refactored to use the stats poller service, so we have single source for metrics.
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
Signed-off-by: Vladimir Lavor <vlavor@cisco.com>
ondrej-fabry
approved these changes
Oct 21, 2019
ondrej-fabry
changed the title
ondrej-fabry
added a commit
to ondrej-fabry/vpp-agent
that referenced
this pull request
Oct 21, 2019
…ato#1532) fix: Allow selectively turn off prometheus metrics and/or stats poller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vladimir Lavor vlavor@cisco.com