test: Traffic test cleanup: bridge, linux route #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
samelias
commented
Oct 25, 2019
samelias
commented
- add polling wait to bridge domain traffic tests after config changes
- remove bridge domain IPv6 variant, bridges don't care about IP version
- fix and enable linux route traffic tests
- remove "routename" from route configuration keywords, no longer used
added 3 commits
October 24, 2019 17:24
Signed-off-by: samuel.elias <samelias@cisco.com>
- remove test cases for route without interface - not supported - update keywords for configuring default routes - remove routename from route keywords, no longer in use - fix IPv6 test logic Signed-off-by: samuel.elias <samelias@cisco.com>
- bridges don't care about IP version, no need to have duplicated tests with IPv6 - add polling wait after configuration is applied Signed-off-by: samuel.elias <samelias@cisco.com>
ondrej-fabry
approved these changes
Oct 25, 2019
Codecov Report
@@ Coverage Diff @@
## dev #1545 +/- ##
==========================================
+ Coverage 52.96% 55.19% +2.23%
==========================================
Files 638 348 -290
Lines 77655 29985 -47670
==========================================
- Hits 41129 16551 -24578
+ Misses 34034 12134 -21900
+ Partials 2492 1300 -1192
|
VladoLavor
changed the title
VladoLavor
approved these changes
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.