build: Cleanup proto generation and fix linter issues #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
changed the title
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Codecov Report
@@ Coverage Diff @@
## dev #1556 +/- ##
==========================================
+ Coverage 52.71% 55.46% +2.75%
==========================================
Files 638 348 -290
Lines 77658 29885 -47773
==========================================
- Hits 40938 16577 -24361
+ Misses 34242 12008 -22234
+ Partials 2478 1300 -1178
|
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
VladoLavor
reviewed
Oct 31, 2019
| @@ -71,14 +71,14 @@ func UnmarshalItem(item *api.Item) (proto.Message, error) { | |||
| } | |||
|
|
|||
| // GetModelForItem returns model for given item. | |||
| func GetModelForItem(item *api.Item) (RegisteredModel, error) { | |||
| func GetModelForItem(item *api.Item) (KnownModel, error) { | |||
There was a problem hiding this comment.
I think RegisteredModel fits more, but if you like it...
There was a problem hiding this comment.
Actually, in the situation when the models are retrieved from remote agent and not from local registry, it might be confusing to label them as registered..
To be honest, Im not certain either way..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proto/buf.make