fix: added GTPU to the interface type guessing function #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed the type guessing for GTPU tunnels. - Added an extra nil check to the GTPU tunnel add and del functions to avoid problems with older VPP releases that still have a broken get api.
Codecov Report
@@ Coverage Diff @@
## dev #1568 +/- ##
==========================================
+ Coverage 52.89% 55.35% +2.46%
==========================================
Files 656 357 -299
Lines 78769 30539 -48230
==========================================
- Hits 41662 16904 -24758
+ Misses 34588 12310 -22278
+ Partials 2519 1325 -1194
|
The GTPU tunnel info can be nil with an old VPP version that has a broken get gtpu tunnel api.
ondrej-fabry
approved these changes
Nov 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid problems with older VPP releases that still have a broken get
api.