refactor: vppcalls and handler version registration #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Nov 26, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Nov 26, 2019
plugins/vpp/ifplugin/vppcalls/vpp1904/dump_interface_vppcalls.go
Outdated
Show resolved
Hide resolved
plugins/vpp/ifplugin/vppcalls/vpp1908/dump_interface_vppcalls.go
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #1572 +/- ##
==========================================
+ Coverage 52.41% 54.08% +1.66%
==========================================
Files 662 370 -292
Lines 79398 31150 -48248
==========================================
- Hits 41617 16847 -24770
+ Misses 35263 12943 -22320
+ Partials 2518 1360 -1158
|
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
# Conflicts: # plugins/vpp/ifplugin/vppcalls/vpp1904/gtpu_vppcalls.go # plugins/vpp/ifplugin/vppcalls/vpp1908/gtpu_vppcalls.go # plugins/vpp/ifplugin/vppcalls/vpp2001/gtpu_vppcalls.go # plugins/vpp/ifplugin/vppcalls/vpp2001_324/gtpu_vppcalls.go
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Nov 26, 2019
plugins/vpp/ifplugin/vppcalls/vpp1904/dump_interface_vppcalls_test.go
Outdated
Show resolved
Hide resolved
plugins/vpp/ifplugin/vppcalls/vpp1904/dump_interface_vppcalls_test.go
Outdated
Show resolved
Hide resolved
plugins/vpp/ifplugin/vppcalls/vpp1904/dump_interface_vppcalls_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Nov 26, 2019
plugins/vpp/ifplugin/vppcalls/vpp1904/dump_interface_vppcalls.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
golangcibot
reviewed
Nov 26, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
# Conflicts: # plugins/vpp/srplugin/srplugin.go
golangcibot
reviewed
Nov 27, 2019
plugins/vpp/ifplugin/vppcalls/vpp1904/dump_interface_vppcalls_test.go
Outdated
Show resolved
Hide resolved
plugins/vpp/ifplugin/vppcalls/vpp1908/dump_interface_vppcalls_test.go
Outdated
Show resolved
Hide resolved
plugins/vpp/ifplugin/vppcalls/vpp2001/dump_interface_vppcalls_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
changed the title
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
rastislavs
approved these changes
Nov 28, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
rewenset
reviewed
Nov 29, 2019
rewenset
reviewed
Nov 29, 2019
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.