feat: Agentctl output format #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
ondrej-fabry
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #1581 +/- ##
==========================================
+ Coverage 50.61% 54.11% +3.49%
==========================================
Files 673 370 -303
Lines 79720 31150 -48570
==========================================
- Hits 40350 16856 -23494
+ Misses 36811 12937 -23874
+ Partials 2559 1357 -1202
|
rewenset
reviewed
Dec 9, 2019
| @@ -168,8 +167,7 @@ func newModelInspectCommand(cli agentcli.Cli) *cobra.Command { | |||
| return runModelInspect(cli, opts) | |||
| }, | |||
| } | |||
| // TODO: add support for custom formatting instead of json | |||
| //cmd.Flags().StringVar(&opts.Format, "format", "", "Format for the output") | |||
| cmd.Flags().StringVarP(&opts.Format, "format", "f", "", "Format for the output") | |||
There was a problem hiding this comment.
why not use "json" as default value here (instead of empty string)?
There was a problem hiding this comment.
To make the default output type configurable globally in the future for all commands. Config for agentctl might define default as yaml then empty string will default to YAML format instead of JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ondrej Fabry ofabry@cisco.com