-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: IPIP tunnel + IPSec tunnel protection support #1638
Conversation
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
Codecov Report
@@ Coverage Diff @@
## master #1638 +/- ##
==========================================
+ Coverage 57.93% 59.03% +1.09%
==========================================
Files 490 288 -202
Lines 39850 23337 -16513
==========================================
- Hits 23089 13778 -9311
+ Misses 14353 8441 -5912
+ Partials 2408 1118 -1290
|
Breaking changes to proto:
|
Yes, this is what I meant with
Those APIs were not used anyhow up till now (at least I don't know about any of their use-case - there was no way to wire SAs to an interface). They will be used going forward. The question is, do we want to keep backward compatibility of unused APIs, or make them cleaner now, when we actually start using them? |
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
Signed-off-by: Rastislav Szabo <raszabo@cisco.com>
VPP 20.01 is deprecating the old IPSec API, in favor of IPIP tunnels with IPSec tunnel protection. This PR adds support for those, which as well fixes the issue with resync of IPSec tunnels on VPP 20.01 which always ended up in a broken state.
The old IPSec tunnel type is marked as deprecated in Ligato API, but still works (but the tunnels are always (correctly) re-programmed during resync).
This PR introduces a type change in the existing IPSec NB API (IPsec SA and SPD indexes), where numeric types were modeled as strings. Since that API was rarely used up till now (there was no need for them when using the old IPSec tunnel type), but will be needed going forward, it is the best time to clean that up now.