refactor: separate model for IPSec Security Policies #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milanlenco
changed the title
Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
==========================================
+ Coverage 56.22% 58.00% +1.78%
==========================================
Files 603 370 -233
Lines 48466 30087 -18379
==========================================
- Hits 27248 17453 -9795
+ Misses 18403 11192 -7211
+ Partials 2815 1442 -1373
Flags with carried forward coverage won't be shown. Click here to find out more. |
rewenset
reviewed
Jul 29, 2020
rewenset
reviewed
Jul 29, 2020
rastislavs
previously approved these changes
Aug 5, 2020
Signed-off-by: Milan Lenco <milan.lenco@pantheon.tech>
rastislavs
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous model of configuring SPs inside SPD is now deprecated. In practice the content of SPD is changing very frequently and using a single model with all SPs inside is therefore neither convenient nor efficient. A new model SecurityPolicy was added which allows to configure each SP as a separate proto message instance. Although the new model is still backward-compatible with the old one, request to configure SP through the SPD model will return an error (invalid config).
Also fixed couple of bugs that were present in the original implementation and tested the implementation with real-world configurations.