Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agentctl): Support specific history seq num and improve layout #1717

Merged
merged 4 commits into from
Sep 3, 2020

Conversation

ondrej-fabry
Copy link
Member

@ondrej-fabry ondrej-fabry commented Aug 28, 2020

  • config history can use classic transaction log format with --format=log
  • config history provides details with --details
  • config update can now print transaction log when using --verbose/-v

Updated layout for config history:

  SEQ  TYPE            START  INPUT      OPERATIONS                    RESULT  SUMMARY                                       
  0    config replace  29m    27 values  DELETE:13                     ok      REMOVED:13                                    
  1    config change   29m    4  values  CREATE:16                     ok      CONFIGURED:16                                 
  2    config change   29m    4  values  CREATE:4, DELETE:4, UPDATE:2  error   CONFIGURED:4, FAILED:1, PENDING:3, REMOVED:2  
  3    config change   29m    4  values  CREATE:3, UPDATE:1            error   CONFIGURED:2, FAILED:1, PENDING:1             
  4    config change   28m    4  values  CREATE:3, UPDATE:1            error   CONFIGURED:2, FAILED:1, PENDING:1     

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1717 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1717      +/-   ##
==========================================
+ Coverage   57.85%   57.92%   +0.06%     
==========================================
  Files         684      444     -240     
  Lines       54885    36315   -18570     
==========================================
- Hits        31754    21035   -10719     
+ Misses      19900    13528    -6372     
+ Partials     3231     1752    -1479     
Flag Coverage Δ
#e2e ?
#unittests 57.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

… layout

Updated layout:

 SEQ     TYPE            START  INPUT      OPERATIONS   RESULT  SUMMARY
    0  ⟱  config replace  50m    17 values  -            ok      Initial resync
    1  ⇩  config change   7m     3  values  11 executed  ok
    2  ⇧  status update   7m     1  values  1  executed  ok
    3  ⇧  status update   7m     1  values  1  executed  ok
    4  ⇅  config check    5m     -          -            ok

Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
@ondrej-fabry ondrej-fabry changed the title feat(agentctl): Support specifying seq num for history and improve layout feat(agentctl): Support specific history seq num and improve layout Sep 2, 2020
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Signed-off-by: Ondrej Fabry <ofabry@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants