feat: Added support for NAT44 static mapping twice-NAT pool IP address reference #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…tion Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
Codecov Report
@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
- Coverage 57.83% 56.34% -1.50%
==========================================
Files 684 444 -240
Lines 55000 32687 -22313
==========================================
- Hits 31811 18416 -13395
+ Misses 19934 12521 -7413
+ Partials 3255 1750 -1505
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hi, what is still WIP in this PR? Can it be merged? |
rastislavs
previously approved these changes
Sep 14, 2020
@rastislavszabo Hi, it is still missing dependecies and error messages. |
…P from twiceNAT address pool Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
…usage Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
fgschwan
changed the title
rastislavs
previously approved these changes
Sep 17, 2020
|
Planning to add any integration or end-to-end tests? |
…ion and previously added twiceNAT pool IP feature Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
|
@ondrej-fabry Added simple integration tests 1fad79a |
rastislavs
approved these changes
Sep 22, 2020
ondrej-fabry
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is new functionality in VPP 20.09.