Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Agentctl support for yaml configuration of 3rd party configuration models #1754

Merged
merged 28 commits into from
Nov 16, 2020
Merged

feat: Agentctl support for yaml configuration of 3rd party configuration models #1754

merged 28 commits into from
Nov 16, 2020

Conversation

fgschwan
Copy link
Collaborator

Fixing issue #1740 .

@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #1754 (b59cf0d) into master (3e6ee30) will decrease coverage by 0.35%.
The diff coverage is 32.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1754      +/-   ##
==========================================
- Coverage   55.70%   55.35%   -0.36%     
==========================================
  Files         386      391       +5     
  Lines       28284    28623     +339     
==========================================
+ Hits        15757    15845      +88     
- Misses      11009    11254     +245     
- Partials     1518     1524       +6
Flag Coverage Δ
unittests 55.35% <32.72%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@fgschwan fgschwan force-pushed the agenctl-custommodels-import branch 2 times, most recently from 73d31a2 to 6e254ee Compare November 3, 2020 11:46
@fgschwan fgschwan changed the title feat: WIP Agentctl support for yaml configuration of 3rd party configuration models feat: Agentctl support for yaml configuration of 3rd party configuration models Nov 3, 2020
@fgschwan fgschwan changed the title feat: Agentctl support for yaml configuration of 3rd party configuration models feat: WIP Agentctl support for yaml configuration of 3rd party configuration models Nov 6, 2020
@fgschwan fgschwan changed the title feat: WIP Agentctl support for yaml configuration of 3rd party configuration models feat: Agentctl support for yaml configuration of 3rd party configuration models Nov 9, 2020
ondrej-fabry
ondrej-fabry previously approved these changes Nov 12, 2020
View reviewed changes
@fgschwan
feat: WIP agentctl support for yaml configuration of 3rd party config…
14e80dd 
…uration models

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed missing type preventing model registration
a97a777 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
refactor: moved file descriptor proto retrieval from helper functions…
a369c86 
… to agentctl (grpc client involved)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed generic client problems related to import of dynamicpb.Mes…
ad4a6fc 
…sage type from dynamic config

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
refactor: cleaned up agentctl import command
53dfa42 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
refactor: cleaned up generic client dynamic config impl
894c43a 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
test: fixed and cleaned up dynamic config unit test
9f01f2a 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed bad recognition of field repeatability by creating dynamic…
65cc38c 
… configuration proto message

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: synced yaml output of dynamic configuration with "agentctl confi…
795e665 
…g get" and extended test to cover it (added test config with more complex field names)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
test: added test for 3rd party model data loading into dynamic config
a9cb74e 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
feat: added almost finished agentctl config get implemented using dyn…
d530d16 
…amic configuration (only placing of retrieved proto.Messages to dynamic config is missing)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: updated cmd line options for agentctl config update and resolved…
332104a 
… some TODOs

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
feat: preparation of type for including MessageDescriptor into return…
a5a69a2 
…ed date for generic.Client KnownModels (+some TODO clarifications)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
feat: added MessageDescriptor to information retrieved by generic cli…
d30b378 
…ent's KnowModel API function

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
refactor: simplified code and API due to moving of MessageDescriptor …
4f115af 
…to generic.Client's KnownModel info retrieval data structure

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
feat: finished agenctl config get by implementing placing of proto me…
17c87e6 
…ssage into dynamic config based on proto message type

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed agentctl config get output showing empty messages more tha…
616fa84 
…n it should and breaking yaml compatibility with hardcoded configurator.Config

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
refactor: removed TODO
ca463b5 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed imports after rebase
1a1fd8c 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
test: fixed generic.Client tests for dynamic config (resolving recent…
7bd9405 
… changes in API)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
feat: enhanced repeated field recognition for 3rd party models (addin…
a95b33a 
…g _list suffix)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
test: moved to pkg/model test proto models in dynamic config unit tes…
fbff46c 
…ts (+ added debugging helper method for partial revealing of dynamic config structure)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
test: clean up
c2348cd 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
refactor: refactored adhoc methods variation using remotely known mod…
0f133e4 
…els into proper structures resembling local model structures

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed bad assumption from previous refactoring
0b1d3e2 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed omitted usage of changed API
3662b38 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
docs: updated info about TODO
cb54cb1 
Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@fgschwan
fix: fixed compatibility with old agentctl yaml output (removed addit…
b653f06 
…ional config root)

Signed-off-by: Filip Gschwandtner <filip.gschwandtner@pantheon.tech>
@ondrej-fabry ondrej-fabry merged commit a6469aa into ligato:master Nov 16, 2020
@fgschwan fgschwan mentioned this pull request Nov 20, 2020
Merged
@ondrej-fabry ondrej-fabry mentioned this pull request Nov 27, 2020
Closed
@fgschwan fgschwan mentioned this pull request Dec 4, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrej-fabry ondrej-fabry Awaiting requested review from ondrej-fabry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgschwan @ondrej-fabry