Unchanged parent class reported as having a missing method #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@2m are the CI failures real...? |
|
AFAICT it's a bug report in the form of a failing CI. If this were old school scala/scala it would be a pending test that would be merged into master/HEAD, which I don't think we can do with MiMa's functional tests (nor do I know if people are against it). |
|
Yup. Exactly. Its a bug reported as a failing test. |
|
I guess I'd suggest closing the PR, opening an issue, and linking the issue to the closed PR, so we can keep the PR queue clear |
|
SGTM. |
|
Created a ticket for this: #211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails with:
but class
Ais unchanged...Originally found in akka/akka-core#24625 (review)