Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macro when interpolated argument is Throwable #305

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

dwickern
Copy link
Contributor

@dwickern dwickern commented Dec 12, 2021

When passing an interpolated string with a Throwable, the Scala 2 macro incorrectly calls the non-format overload:

public void error(String msg, Throwable t);

Coerce all arguments to AnyRef so that the format overload is used:

public void error(String format, Object arg);

Fixes #216
Fixes #95

@analytically analytically merged commit 22a497e into lightbend-labs:main Dec 30, 2021
@dwickern dwickern deleted the interpolated-throwable branch December 30, 2021 16:52
@kamilkloch
Copy link

When can we expect a release with a fix? :)

@mox692
Copy link
Collaborator

mox692 commented Aug 30, 2023

The release that includes this change has been published as v3.9.5. However, unfortunately, it seems that the original problem described in the issue has not been resolved even in the latest release :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants