Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable the Scala Steward #48

Open
agemooij opened this issue Dec 2, 2019 · 4 comments
Open

Enable the Scala Steward #48

agemooij opened this issue Dec 2, 2019 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Issues that the core team will likely not have time to work on. Community help is wanted. kind/enhancement New feature or request. priority/nice-to-have Low priority item. status:blocked An issue is blocked, no progress can be made.

Comments

@agemooij
Copy link
Contributor

agemooij commented Dec 2, 2019

Scala Steward helps to stay up to date on dependencies.
@agemooij agemooij added kind/enhancement New feature or request. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Issues that the core team will likely not have time to work on. Community help is wanted. priority/nice-to-have Low priority item. labels Dec 2, 2019
@osleonard
Copy link
Contributor

Created a PR for this https://github.com/scala-steward-org/repos/pull/97

@agemooij
Copy link
Contributor Author

agemooij commented Dec 3, 2019

Thanks @osleonard!

I wonder whether this will work out of the box though, since the actual Scala/sbt project is located one level deeper than the root of the repo, e.g. in the core folder.

I couldn't find any quick info on how to configure Scala Steward to look at a sub-folder of a project so let's see what happens first.

@agemooij
Copy link
Contributor Author

agemooij commented Dec 4, 2019

It seems this is blocked by scala-steward-org/scala-steward#46, e.g. Scala Steward doesn't currently work on projects without an sbt project in the root. There is an open PR to fix that.

@agemooij agemooij added the status:blocked An issue is blocked, no progress can be made. label Dec 4, 2019
maasg pushed a commit that referenced this issue Apr 28, 2020
@yuchaoran2011
Fixed path to sensor data example (#48)
b2d08f9 
* Fixed path to sensor data example

* Updated the URL to point to snippets subdir

* Additional fixes
@Lockdain Lockdain mentioned this issue Oct 19, 2020
Closed
@thomasschoeftner
Copy link
Contributor

Can this be closed? Scala Steward is in use now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Issues that the core team will likely not have time to work on. Community help is wanted. kind/enhancement New feature or request. priority/nice-to-have Low priority item. status:blocked An issue is blocked, no progress can be made.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agemooij @osleonard @thomasschoeftner