Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Add new saveAppGraph sbt task #1020

Merged
merged 6 commits into from
Apr 15, 2021
Merged

Conversation

Lockdain
Copy link
Contributor

@Lockdain Lockdain commented Apr 9, 2021

What changes were proposed in this pull request?

This PR introduces a new sbt-task saveAppGraph which allows to save an ASCII blueprint graph visualization to the appGraph.txt file under the /blueprint folder.

Why are the changes needed?

Sometimes it's handy to see a visualized representation of a given project. Especially in cases when a project contains a lot of streamlets and intermediate kafka topics.
The task can update the file on each compilation, so the visualization would be instantly ready to any team member to explore if needed.

Does this PR introduce any user-facing change?

Yes. It adds a new sbt task.

How was this patch tested?

Was tested locally.

@Lockdain Lockdain changed the title Save app graph task Add new saveAppGraph sbt task Apr 9, 2021
@Lockdain
Copy link
Contributor Author

Lockdain commented Apr 9, 2021

The tests failed due to inavailability of a Spark driver during the run. So the PR is not a reason.
@RayRoestenburg @andreaTP I kindly request your review.

Copy link
Contributor

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions, I like this addition thanks!
Can you please have a scripted test for it to avoid regressions in the future?

@Lockdain
Copy link
Contributor Author

I made a few suggestions, I like this addition thanks!
Can you please have a scripted test for it to avoid regressions in the future?

Did a scripted test that covers both old printAppGraph and new saveAppGraph tasks.

@Lockdain
Copy link
Contributor Author

@andreaTP Hi!
Discussions are resolved.

@Lockdain Lockdain requested a review from andreaTP April 15, 2021 09:05
@RayRoestenburg RayRoestenburg self-requested a review April 15, 2021 13:43
@andreaTP
Copy link
Contributor

Thanks!

@andreaTP andreaTP merged commit 2adfb5e into lightbend:master Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants