This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests failed due to inavailability of a Spark driver during the run. So the PR is not a reason. |
andreaTP
suggested changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few suggestions, I like this addition thanks!
Can you please have a scripted
test for it to avoid regressions in the future?
tools/cloudflow-sbt-plugin/src/main/scala/cloudflow/sbt/CloudflowKeys.scala
Outdated
Show resolved
Hide resolved
tools/cloudflow-sbt-plugin/src/main/scala/cloudflow/sbt/CloudflowLocalRunnerPlugin.scala
Outdated
Show resolved
Hide resolved
tools/cloudflow-sbt-plugin/src/main/scala/cloudflow/sbt/CloudflowLocalRunnerPlugin.scala
Show resolved
Hide resolved
Did a scripted test that covers both old |
@andreaTP Hi! |
RayRoestenburg
approved these changes
Apr 15, 2021
andreaTP
approved these changes
Apr 15, 2021
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR introduces a new sbt-task
saveAppGraph
which allows to save an ASCII blueprint graph visualization to theappGraph.txt
file under the/blueprint
folder.Why are the changes needed?
Sometimes it's handy to see a visualized representation of a given project. Especially in cases when a project contains a lot of streamlets and intermediate kafka topics.
The task can update the file on each compilation, so the visualization would be instantly ready to any team member to explore if needed.
Does this PR introduce any user-facing change?
Yes. It adds a new sbt task.
How was this patch tested?
Was tested locally.