Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Fix to report streamlet scanning errors #1061

Merged
merged 7 commits into from
Jun 3, 2021

Conversation

RayRoestenburg
Copy link
Contributor

@RayRoestenburg RayRoestenburg commented Jun 2, 2021

What changes were proposed in this pull request?

The sbt plugin keeps track of the problems found scanning for streamlets and provides these as problems on the blueprint.

Why are the changes needed?

User reported issue, a Streamlet used the StreamletContext from outside of the logic, which means that the Streamlet cannot be constructed for extracting the streamlet.

This results in feedback during verification of blueprint that is confusing:
[error] ClassName sensordata.ValidMetricLogger for valid-logger cannot be found.

The cause was missing, which is:

[error] Streamlet 'sensordata.ValidMetricLogger' could not be instantiated for introspection. Its constructor threw an StreamletContextException: StreamletContext can only be accessed from the `createLogic()` method.

Does this PR introduce any user-facing change?

The type of the allStreamletDescriptorsByProject taskKey has been changed (which users should usually not need to use directly)

How was this patch tested?

Tested with an example project, and current unit tests for scanning for streamlets.

@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@RayRoestenburg RayRoestenburg force-pushed the fix_reporting_scan_errors branch from 68e65b7 to 2161c28 Compare June 2, 2021 19:12
@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@RayRoestenburg RayRoestenburg force-pushed the fix_reporting_scan_errors branch from 2161c28 to 451108d Compare June 2, 2021 19:13
@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@RayRoestenburg
Copy link
Contributor Author

wow I must have changed something in my github user settings lol
image

@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

3 similar comments
@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@RayRoestenburg RayRoestenburg force-pushed the fix_reporting_scan_errors branch from 3237ca1 to b5dad19 Compare June 3, 2021 07:27
@lightbend-cla-validator
Copy link
Collaborator

At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user

@RayRoestenburg RayRoestenburg force-pushed the fix_reporting_scan_errors branch from b5dad19 to 7019d01 Compare June 3, 2021 07:31
@RayRoestenburg RayRoestenburg force-pushed the fix_reporting_scan_errors branch from 7019d01 to 2040eee Compare June 3, 2021 07:34
@RayRoestenburg RayRoestenburg merged commit 86066f9 into master Jun 3, 2021
@RayRoestenburg RayRoestenburg deleted the fix_reporting_scan_errors branch June 3, 2021 18:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants