Encode the protocol version in the CRD #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| .apiextensions() | ||
| .v1beta1() | ||
| .customResourceDefinitions() |
There was a problem hiding this comment.
Does this need cluster admin / wide permissions?
There was a problem hiding this comment.
It's probably a good idea to have a yaml that specifies exactly which permissions CLI needs to function, similar to https://github.com/lightbend/cloudflow-helm-charts/blob/main/cloudflow/templates/02-cloudflow-operator-clusterrole.yaml, what do you think?
There was a problem hiding this comment.
that's a good idea, have to think how to produce it, maybe running the cli from within the cluster and checking permissions.
andreaTP
force-pushed
the
protocol-version-crd
branch
from
fa0d999
to
d264abe
Compare
| val ProtocolVersion = "6" | ||
|
|
||
| val SupportedApplicationDescriptorVersion = 6 | ||
| val ApplicationDescriptorVersion = 6 |
There was a problem hiding this comment.
even ApplicationDescriptor ?
There was a problem hiding this comment.
Oh wait. No you are right, this stays the same.
andreaTP
force-pushed
the
protocol-version-crd
branch
from
d264abe
to
16afffe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the version validation to the CRD from the ConfigMap.