Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to lightbend repo #510

Closed
wants to merge 1 commit into from
Closed

Migration to lightbend repo #510

wants to merge 1 commit into from

Conversation

2m
Copy link
Contributor

@2m 2m commented Oct 16, 2017

Fixing the fallout after #509

ktoso
ktoso approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks, let's create the gitter channel

marcospereira
marcospereira reviewed Oct 16, 2017
View reviewed changes
README.md Outdated
@@ -198,7 +198,7 @@ There isn't a schema language or anything like that. However, two
suggested tools are:

- use the
[checkValid() method](http://typesafehub.github.io/config/latest/api/com/typesafe/config/Config.html#checkValid-com.typesafe.config.Config-java.lang.String...-)
[checkValid() method](http://lghtbend.github.io/config/latest/api/com/typesafe/config/Config.html#checkValid-com.typesafe.config.Config-java.lang.String...-)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lghtbend.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching.

@2m 2m force-pushed the wip-lightbend-2m branch 2 times, most recently from 657a2e3 to 632bd07 Compare October 17, 2017 14:38
@dwijnand
Copy link
Member

There's a lot more than 26 instances:

$ git show-ref HEAD
08f5a6020ea0770440529ff9d0e2191c72367bec refs/remotes/origin/HEAD
$ git grep typesafehub | wc -l
      65

@2m
Copy link
Contributor Author

2m commented Oct 17, 2017

Thanks for noticing. IntelliJ did not replace all of the occurences. And there is something strange with this PR where it does not show the new commits I pushed to the branch. I will reopen this PR.

@2m 2m closed this Oct 17, 2017
@2m 2m mentioned this pull request Oct 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcospereira marcospereira marcospereira left review comments

@ktoso ktoso ktoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2m @dwijnand @marcospereira @ktoso