Inherit optional and getter evaluation #660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to sbt 0.13.16
#495 Add Support For Set Types In Config Beans
Add fallback ConfigReferenceResolver
Add support for getting value as Period
Release notes for 1.3.2
Add C# port to Other APIs section
* Migration to lightbend repo * Second round of the rename cleanup
Align maintanance note with other lightbend/ projects
Add circe-config to list of Scala wrappers
Fixes #546. Adds Automatic-Module-Name: typesafe.config, rather than defaulting to the very generic module name of config that the JVM selects.
update version to 1.3.2
news for 1.3.3
Adds trace while allowing missing file by returing empty parse value
Update to the latest sbt-pgp
Typo in the year
Typo in the NEWS.md
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Co-Authored-By: raboof <github@bzzt.net>
Fix spelling typo in readme
Update README to include sconfig supported platforms
* Note in README that substitutions don’t work inside quotes There’s more on this in HOCON.md but can’t hurt to repeat, people do miss it.
Test on JDK 11
* Allow application.conf to override variables in reference.conf Fixes #167 This only affects the output of `ConfigFactory.load`. It does not change `ConfigFactory.defaultReference`. This uses the unresolved `reference.conf` in the building of configuration in `ConfigFactory.load`, effectively allowing `application.conf` properties to override variable substitutions in `reference.conf`. However, it still requires `reference.conf` to be fully resolvable, if it isn't, an exception will be thrown. So two resolves are still done during load, it's just that the output of the resolve of `reference.conf` isn't used in building the final configuration. The documentation has been updated to reflect this behavior. The reasoning behind this change can be read about in #167, but essentially, it is not uncommon for configuration properties to depend on each other by default, a good example of this is directory hierarchies, where you might have a configuration option for a base directory, and then a configuration for the log directory that by default is under the base directory, and within that a configuration for individual log files which by default are under the log directory. Without allowing variable substitutions in `reference.conf` from `application.conf`, there is no point in defining a configuration option for the base directory since changing it won't have any impact, and each path defined that depends on it will have to be manually overridden. This limitation is contrary to convention over configuration best practices, and hence not desirable in a configuration library. * Renamed public method to defaultReferenceUnresolved Also added the methods to ConfigFactory, as requested in code review.
…en adding elements
Performance fix: added capacity parameter in ArrayLists
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
|
Hi @fabiofumarola, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Tried to rewrite git history for my username and mail to match the CLA but that went wrong :-) . I'll give it another try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added @inherited to @optional and an extra evaluation for the presence of @optional at getter if the field exists. All tests passing but maybe someone can give me a hint where I can implement an extra test for my changes if necessary.
I signed the Lightbend CLA.
closes #659