Skip to content

support JDK 10 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xuwei-k opened this issue Aug 17, 2018 · 3 comments · Fixed by #240
Closed

support JDK 10 #235

xuwei-k opened this issue Aug 17, 2018 · 3 comments · Fixed by #240
Milestone
0.4.3

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Aug 17, 2018

pegdown depends on parboiled, parboiled depends on asm 5.2, asm 5.2 does not work with JDK10 😢

https://github.com/sirthias/parboiled/blob/04277952b8df3f6b76067c5a456aece721ecc00c/project/Dependencies.scala#L15-L18

related to #81
@xuwei-k xuwei-k mentioned this issue Aug 17, 2018
Closed
@ijuma
Copy link

ijuma commented Aug 18, 2018

Is it just a matter of upgrading to ASM 6.2.1?

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Aug 19, 2018

sirthias/parboiled#123

@ktoso ktoso mentioned this issue Aug 21, 2018
Merged
@xuwei-k xuwei-k mentioned this issue Sep 15, 2018
Merged
@2m 2m closed this as completed in #240 Sep 18, 2018
@2m 2m added this to the 0.4.3 milestone Sep 18, 2018
@SethTisue
Copy link
Contributor

paradox is now green at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/249/consoleFull 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.3
Development

Successfully merging a pull request may close this issue.

jdk10 support xuwei-k/paradox
4 participants
@ijuma @SethTisue @xuwei-k @2m