Skip to content

add JDK 10 community build #735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Jun 20, 2018 · 21 comments
Closed

add JDK 10 community build #735

SethTisue opened this issue Jun 20, 2018 · 21 comments
Assignees

Comments

@SethTisue
Copy link
Member

there is sufficient capacity on the behemoths.

if we run low on capacity, we could eventually drop the JDK 9 community build and just do 10 (and/or 11)

@SethTisue
Copy link
Member Author

I made the job at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/ and queued a first run

presumably it will fail because JDK 10 isn't installed yet. (if it doesn't fail, I should look into that.)

@SethTisue
Copy link
Member Author

so far so good:

+ echo 'Failed to locate openjdk Java 10 in /usr/lib/jvm/, containing:'
Failed to locate openjdk Java 10 in /usr/lib/jvm/, containing:
+ find /usr/lib/jvm/ -name java
/usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java
/usr/lib/jvm/java-8-openjdk-amd64/bin/java
/usr/lib/jvm/java-9-openjdk-amd64/bin/java
+ exit 1
Build step 'Execute shell' marked build as failure

@SethTisue
Copy link
Member Author

SethTisue commented Jun 26, 2018

steps I followed for installing OpenJDK 10:

  • use instructions at https://stackoverflow.com/a/49507161/86485 as a guide
  • go to http://jdk.java.net/10/
  • copy URL of Linux tarball
  • curl -O 'https://download.java.net/java/GA/jdk10/10.0.1/fb4372174a714e6b8c52526dc134031e/10//openjdk-10.0.1_linux-x64_bin.tar.gz'
  • sudo mv openjdk-10.0.1_linux-x64_bin.tar.gz /usr/lib/jvm
  • cd /usr/lib/jvm
  • sudo tar xzf openjdk-10.0.1_linux-x64_bin.tar.gz
  • sudo rm openjdk-10.0.1_linux-x64_bin.tar.gz
  • sudo mv jdk-10.0.1 java-10-openjdk-amd64 <-- should have been x64 not amd64
  • sudo update-alternatives --install /usr/bin/java java /usr/lib/jvm/java-10-openjdk-amd64/bin/java 1
  • sudo update-alternatives --install /usr/bin/javac javac /usr/lib/jvm/java-10-openjdk-amd64/bin/javac 1

@SethTisue
Copy link
Member Author

new run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/2/

I see export JAVA_HOME=/usr/lib/jvm/java-10-openjdk-amd64 so it's off to a good start, I'll come back tomorrow to check on it

@SethTisue
Copy link
Member Author

hmm I see I lied about x64 vs amd64 above, assuming this is working I'll go back and straighten that out.

@SethTisue
Copy link
Member Author

yay, everything extracts 🎉

first real run in progress: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/14/

@SethTisue
Copy link
Member Author

SethTisue commented Jun 29, 2018

scala-js-stubs is failing (which takes out much of the build) because the behemoth doesn't have rt.jar in the right place. so that's the next fix

@SethTisue
Copy link
Member Author

SethTisue commented Jun 29, 2018

note that I've moved the JDK 10 job to behemoth 1. behemoth 2 was getting overloaded

@SethTisue
Copy link
Member Author

installed JDK 10 on behemoth 1 using the above instructions (but with the amd64/x64 mistake fixed)

@SethTisue
Copy link
Member Author

on behemoth 2, fixed the directory naming with

sudo update-alternatives --remove java /usr/lib/jvm/java-10-openjdk-amd64/bin/java
sudo update-alternatives --remove javac /usr/lib/jvm/java-10-openjdk-amd64/bin/javac
cd /usr/lib/jvm
sudo mv java-10-openjdk-amd64 java-10-openjdk-x64
sudo update-alternatives --install /usr/bin/java java /usr/lib/jvm/java-10-openjdk-x64/bin/java 1
sudo update-alternatives --install /usr/bin/javac javac /usr/lib/jvm/java-10-openjdk-x64/bin/javac 1

@SethTisue
Copy link
Member Author

behemoth 1 now has rt.jar in the right places, I think. let's see where scala-js-stubs goes green in https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/21/

@SethTisue
Copy link
Member Author

some projects are currently failing to extract again, so I'll have to get that straightened out before we can see how scala-js-stubs is doing

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

let's see how the next test run does. I think we are close to being able to declare victory here. where victory is defined not as the whole build being green, but having approximately as much green as the JDK 9 build does, no key projects failing and taking out big swathes of the build

@SethTisue
Copy link
Member Author

as of https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/110/console we have: scala-async, paradox, log4s, slick, jsoniter-scala, twitter-util, http4s-websocket, jawn-0-10, scalaz8, scala-partest, jawn-0-11, kxbmap-configs, fs2, breeze, akka-stream, curryhoward

many of these fail on 9 as well; see #609.

the log4s, jawn-0-10, and jawn-0-11 failures would be especially good to address. these do not fail on 9.

@xuwei-k
Copy link
Contributor

xuwei-k commented Aug 17, 2018

lightbend/paradox#235

@ijuma
Copy link

ijuma commented Aug 18, 2018

Nice. Btw, I think it's fine to drop the Java 9 build once the Java 10 build is in good shape.

@xuwei-k
Copy link
Contributor

xuwei-k commented Sep 15, 2018

FYI sbt/sbt#4350

@SethTisue
Copy link
Member Author

closing since the JDK 10 build has been in reasonably good shape for a while now and anyway the action is now on 11 (#742)

@SethTisue
Copy link
Member Author

I've deleted the JDK 10 job from Jenkins. 8 and 11 only now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants