compiler does not work with "-opt:l:method" on JDK10 #10717

xuwei-k · 2018-02-12T01:50:05Z

package example

class Foo

$ scala -version
Scala code runner version 2.13.0-M3 -- Copyright 2002-2018, LAMP/EPFL and Lightbend, Inc.
$ java -version
java version "10-ea" 2018-03-20
Java(TM) SE Runtime Environment 18.3 (build 10-ea+42)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10-ea+42, mixed mode)
$ scalac -opt:l:method Foo.scala
error: java.lang.IllegalArgumentException
	at scala.tools.asm.ClassReader.<init>(ClassReader.java:160)
	at scala.tools.asm.ClassReader.<init>(ClassReader.java:143)
	at scala.tools.nsc.backend.jvm.opt.ByteCodeRepository.$anonfun$parseClass$1(ByteCodeRepository.scala:257)
	at scala.tools.nsc.backend.jvm.opt.ByteCodeRepository.parseClass(ByteCodeRepository.scala:255)
	at scala.tools.nsc.backend.jvm.opt.ByteCodeRepository.$anonfun$parsedClassNode$1(ByteCodeRepository.scala:70)
	at scala.collection.mutable.MapLike.getOrElseUpdate(MapLike.scala:202)
	at scala.collection.mutable.MapLike.getOrElseUpdate$(MapLike.scala:199)
	at scala.collection.mutable.AbstractMap.getOrElseUpdate(Map.scala:80)
	at scala.tools.nsc.backend.jvm.opt.ByteCodeRepository.parsedClassNode(ByteCodeRepository.scala:70)
	at scala.tools.nsc.backend.jvm.opt.ByteCodeRepository.classNode(ByteCodeRepository.scala:91)
	at scala.tools.nsc.backend.jvm.opt.ByteCodeRepository.methodNode(ByteCodeRepository.scala:239)
	at scala.tools.nsc.backend.jvm.opt.CallGraph.$anonfun$addMethod$2(CallGraph.scala:151)
	at scala.tools.nsc.backend.jvm.opt.CallGraph.$anonfun$addMethod$2$adapted(CallGraph.scala:148)
	at scala.collection.Iterator.foreach(Iterator.scala:938)
	at scala.collection.Iterator.foreach$(Iterator.scala:938)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1426)
	at scala.tools.nsc.backend.jvm.opt.CallGraph.addMethod(CallGraph.scala:148)
	at scala.tools.nsc.backend.jvm.opt.CallGraph.$anonfun$addClass$1(CallGraph.scala:107)
	at scala.tools.nsc.backend.jvm.opt.CallGraph.$anonfun$addClass$1$adapted(CallGraph.scala:107)
	at scala.collection.Iterator.foreach(Iterator.scala:938)
	at scala.collection.Iterator.foreach$(Iterator.scala:938)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1426)
	at scala.collection.IterableLike.foreach(IterableLike.scala:71)
	at scala.collection.IterableLike.foreach$(IterableLike.scala:70)
	at scala.collection.AbstractIterable.foreach(Iterable.scala:54)
	at scala.tools.nsc.backend.jvm.opt.CallGraph.addClass(CallGraph.scala:107)
	at scala.tools.nsc.backend.jvm.PostProcessor.$anonfun$runGlobalOptimizations$3(PostProcessor.scala:86)
	at scala.tools.nsc.backend.jvm.PostProcessor.$anonfun$runGlobalOptimizations$3$adapted(PostProcessor.scala:84)
	at scala.collection.TraversableLike$WithFilter.$anonfun$foreach$1(TraversableLike.scala:785)
	at scala.collection.immutable.List.foreach(List.scala:389)
	at scala.collection.generic.TraversableForwarder.foreach(TraversableForwarder.scala:35)
	at scala.collection.generic.TraversableForwarder.foreach$(TraversableForwarder.scala:35)
	at scala.collection.mutable.ListBuffer.foreach(ListBuffer.scala:44)
	at scala.collection.TraversableLike$WithFilter.foreach(TraversableLike.scala:784)
	at scala.tools.nsc.backend.jvm.PostProcessor.runGlobalOptimizations(PostProcessor.scala:84)
	at scala.tools.nsc.backend.jvm.PostProcessor.postProcessAndSendToDisk(PostProcessor.scala:46)
	at scala.tools.nsc.backend.jvm.GenBCode$BCodePhase.$anonfun$run$1(GenBCode.scala:54)
	at scala.tools.nsc.backend.jvm.GenBCode$BCodePhase.run(GenBCode.scala:51)
	at scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1453)
	at scala.tools.nsc.Global$Run.compileUnits(Global.scala:1437)
	at scala.tools.nsc.Global$Run.compileSources(Global.scala:1429)
	at scala.tools.nsc.Global$Run.compile(Global.scala:1546)
	at scala.tools.nsc.Driver.doCompile(Driver.scala:35)
	at scala.tools.nsc.MainClass.doCompile(Main.scala:24)
	at scala.tools.nsc.Driver.process(Driver.scala:55)
	at scala.tools.nsc.Driver.main(Driver.scala:68)
	at scala.tools.nsc.Main.main(Main.scala)

The text was updated successfully, but these errors were encountered:

xuwei-k · 2018-02-17T16:19:47Z

lrytz · 2018-02-28T13:21:35Z

So this issue should fix itself when we upgrade to asm 6.1 (not yet released), which will include the two commits listed above.

lrytz · 2018-03-12T07:08:55Z

6.1 is released now https://mail.ow2.org/wws/arc/asm/2018-03/msg00000.html

ijuma · 2018-03-23T05:08:24Z

Is there a plan to upgrade to ASM 6.1 in the Scala 2.12 series?

lrytz · 2018-03-23T13:26:50Z

In general we keep ASM up to date, so I'll probably do it for 2.12. Watching the asm issue tracker, I saw one regression in 6.1 that might be relevant to us: https://gitlab.ow2.org/asm/asm/issues/317815. If we do the update we need to look at this in more detail to see if it affects us. In any case, I'm busy right now with other stuff :)

ijuma · 2018-03-23T13:55:43Z

Thanks for the information.

mkurz · 2018-03-26T17:16:20Z

ASM 6.1.1 has been tagged and also availabe via the maven repos already.
https://gitlab.ow2.org/asm/asm/tags

Abhi-joshi · 2018-03-28T19:30:08Z

@lrytz Feasible in 2.12.6?

Andrei-Pozolotin · 2018-04-03T23:12:45Z

version "10-ea" 2018-03-20 and 18.3 ? :-)

adriaanm · 2018-04-04T10:01:25Z

We will (carefully) consider an ASM upgrade for 2.12.7, but not 2.12.6.

adriaanm · 2018-04-04T10:04:42Z

It would be a big help if someone could submit our patches in scala/scala-asm upstream to https://gitlab.ow2.org/asm/asm, so that we could switch to using an official asm release. That would simplify upgrading to the latest ASM a lot! (EDIT: the differences are small, but essential for us -- we think they could all go upstream, but just haven't found the time to do so...)

plokhotnyuk · 2018-04-27T10:44:05Z

I got the same compiler crash on JDK 10 with Scala 2.12.x.

/usr/lib/jvm/jdk-10/bin/java -version
java version "10" 2018-03-20
Java(TM) SE Runtime Environment 18.3 (build 10+46)
Java HotSpot(TM) 64-Bit Server VM 18.3 (build 10+46, mixed mode)

Sources: https://github.com/plokhotnyuk/jsoniter-scala
Command to reproduce:
sbt -java-home /usr/lib/jvm/jdk-10 -no-colors clean test

It fails with 2.12.4 too, but works fine for 2.11.12:
sbt -java-home /usr/lib/jvm/jdk-10 -no-colors ++2.11.12 clean test

lrytz · 2018-05-04T05:13:27Z

Just for reference; ASM 6.1.x has an issue that might affect us (https://gitlab.ow2.org/asm/asm/merge_requests/160), which will be fixed only in 6.2

eed3si9n · 2018-05-06T06:37:18Z

On JDK 10 I am getting the same while compiling Zinc, which recently added List("-opt-inline-from:<sources>", "-opt:l:inline", "-Yopt-inline-heuristics:at-inline-annotated") sbt/zinc#492

mkurz · 2018-05-30T09:41:33Z

ASM 6.2 released with better JDK 10 support and even with JDK 11 support already!
http://asm.ow2.io/versions.html
https://gitlab.ow2.org/asm/asm/tags
https://gitlab.ow2.org/asm/asm/issues/317830

xuwei-k · 2018-06-06T04:57:50Z

scala/scala#6733

Switch to oraclejdk10 for Scala 2.11.12 only, it doesn't compile for 2.12.6, see scala/bug#10717

plokhotnyuk · 2018-06-29T14:17:52Z

@lrytz referenced pr merged to 2.13.x branch only... will it be backported to 2.12.x?

lrytz · 2018-06-29T14:24:23Z

it should be, let's keep this open.

xuwei-k · 2018-09-12T12:37:19Z

scala/scala#7089

xuwei-k · 2019-01-19T03:16:21Z

FYI, similar issue with JDK12+ #11372

xuwei-k mentioned this issue Feb 12, 2018

Support features of JDK 11+ scala/scala-dev#139

Open

16 tasks

SethTisue added jdk10 [obsolete] backend labels Feb 12, 2018

SethTisue added this to the 2.13.0-RC1 milestone Feb 17, 2018

lrytz self-assigned this Feb 28, 2018

SethTisue modified the milestones: 2.13.0-RC1, 2.12.7 Apr 27, 2018

SethTisue changed the title ~~Scala 2.13.0-M3 compiler does not work with "-opt:l:method" on JDK10~~ compiler does not work with "-opt:l:method" on JDK10 Apr 27, 2018

hrhino mentioned this issue May 19, 2018

2.12.6: random IllegalArgumentException somewhere in nsc.backend.jvm.CodeGen #10891

Closed

retronym mentioned this issue Jun 7, 2018

Upgrade to scala-asm 6.2 scala/scala#6733

Merged

dispalt mentioned this issue Jun 19, 2018

* Introduce some scalac params in order to improve the emited bytecode kamon-io/Kamon#521

Merged

plokhotnyuk added a commit to plokhotnyuk/jsoniter-scala that referenced this issue Jun 25, 2018

Switch to oraclejdk10 (#130)

435e332

Switch to oraclejdk10 for Scala 2.11.12 only, it doesn't compile for 2.12.6, see scala/bug#10717

lrytz closed this as completed in scala/scala#6733 Jun 29, 2018

lrytz reopened this Jun 29, 2018

SethTisue added the blocker label Jul 12, 2018

xuwei-k mentioned this issue Jul 14, 2018

Compiler crash while compiling with JDK 10 #11022

Closed

SethTisue mentioned this issue Jul 18, 2018

add JDK 10 community build scala/community-build#735

Closed

jdegoes mentioned this issue Jul 22, 2018

Error compiling project zio/zio#130

Closed

SethTisue mentioned this issue Aug 13, 2018

Class jdk.internal.HotSpotIntrinsicCandidate not found - continuing with a stub. #10959

Closed

ElfoLiNk mentioned this issue Aug 18, 2018

[backport] Upgrade to scala-asm 6.2 scala/scala#7089

Merged

SethTisue mentioned this issue Sep 1, 2018

Retire this fork scala/scala-asm#9

Open

xuwei-k closed this as completed Sep 12, 2018

SethTisue assigned retronym Sep 17, 2018

SethTisue mentioned this issue Sep 19, 2018

akka-stream not compiling on JDK 10 in Scala community build akka/akka#25461

Closed

xuwei-k mentioned this issue Aug 9, 2019

scalac 2.12.9 and 2.13.0 does not work with "-opt:l:method" on JDK13+ #11671

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

compiler does not work with "-opt:l:method" on JDK10 #10717

compiler does not work with "-opt:l:method" on JDK10 #10717

xuwei-k commented Feb 12, 2018 •

edited

Loading

xuwei-k commented Feb 17, 2018

lrytz commented Feb 28, 2018

lrytz commented Mar 12, 2018

ijuma commented Mar 23, 2018

lrytz commented Mar 23, 2018

ijuma commented Mar 23, 2018

mkurz commented Mar 26, 2018

Abhi-joshi commented Mar 28, 2018

Andrei-Pozolotin commented Apr 3, 2018

adriaanm commented Apr 4, 2018

adriaanm commented Apr 4, 2018 •

edited

Loading

plokhotnyuk commented Apr 27, 2018 •

edited

Loading

lrytz commented May 4, 2018

eed3si9n commented May 6, 2018

mkurz commented May 30, 2018

xuwei-k commented Jun 6, 2018

plokhotnyuk commented Jun 29, 2018

lrytz commented Jun 29, 2018

xuwei-k commented Sep 12, 2018

xuwei-k commented Jan 19, 2019

compiler does not work with "-opt:l:method" on JDK10 #10717

compiler does not work with "-opt:l:method" on JDK10 #10717

Comments

xuwei-k commented Feb 12, 2018 • edited Loading

xuwei-k commented Feb 17, 2018

lrytz commented Feb 28, 2018

lrytz commented Mar 12, 2018

ijuma commented Mar 23, 2018

lrytz commented Mar 23, 2018

ijuma commented Mar 23, 2018

mkurz commented Mar 26, 2018

Abhi-joshi commented Mar 28, 2018

Andrei-Pozolotin commented Apr 3, 2018

adriaanm commented Apr 4, 2018

adriaanm commented Apr 4, 2018 • edited Loading

plokhotnyuk commented Apr 27, 2018 • edited Loading

lrytz commented May 4, 2018

eed3si9n commented May 6, 2018

mkurz commented May 30, 2018

xuwei-k commented Jun 6, 2018

plokhotnyuk commented Jun 29, 2018

lrytz commented Jun 29, 2018

xuwei-k commented Sep 12, 2018

xuwei-k commented Jan 19, 2019

xuwei-k commented Feb 12, 2018 •

edited

Loading

adriaanm commented Apr 4, 2018 •

edited

Loading

plokhotnyuk commented Apr 27, 2018 •

edited

Loading