Update sbt in generated-source scripted test #364
Conversation
| @@ -1 +1 @@ | |||
| sbt.version=1.2.8 | |||
| sbt.version=1.3.0 | |||
There was a problem hiding this comment.
Wouldn't it be better to just delete this file? I don't think it's needed, or wanted.
There was a problem hiding this comment.
I have no preference
There was a problem hiding this comment.
I think it should be deleted, otherwise we'll have to manually update it every time we upgrade sbt. No other scripted tests have it.
There was a problem hiding this comment.
actually there are 2 more and they're automatically updated by scala-steward - but anyway updated
There was a problem hiding this comment.
Agree about not having sbt versions in the scripted tests, and also wondered about that in #357.
Although it could also be useful to have scripted tests that do explicitly test different sbt versions, to make sure we don't have something like the upgrade to sbt 1.3 breaking sbt 1.2 usage.
|
@pvlugter agreed on that, I think that could be achieved by doing something like this: |
No description provided.