Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize & handle brotli compression of the response body #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

n0m0r3pa1n
Copy link

I needed Brotli compression recognition because I wanted to get some data from Facebook which use this algorithm.

@hidenny
Copy link

hidenny commented Aug 13, 2018

Hello @n0m0r3pa1n do you have a complied Jar file with brotli supported? I have tried to edit and compile, however it shows an error "Caused by: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown" in my project.

Many thanks!!!

@Fohlen
Copy link

Fohlen commented Sep 16, 2018

Hello @jekh
I tested these changes and verified that it works on resources where brotli compression is enabled.
What needs to be done in order to merge this to master and make a release?

Also @hidenny you can ask me for a compiled version, if you like.

Copy link

@Fohlen Fohlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems fine.
However I wonder why doesn't the meteorgroup compile this changes somewhere? Using a private brotli upload seems a bit weird.

</dependencies>
<repositories>
<repository>
<id>bintray-nitram509-jbrotli</id>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not rely on a private bintray repo, why is there no official build?

@ericbeland
Copy link

We released brotli support on our fork today.

@millievn
Copy link

millievn commented Aug 9, 2022

same issue. why is not merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants