-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize & handle brotli compression of the response body #742
base: master
Are you sure you want to change the base?
Conversation
Hello @n0m0r3pa1n do you have a complied Jar file with brotli supported? I have tried to edit and compile, however it shows an error "Caused by: javax.net.ssl.SSLException: Received fatal alert: certificate_unknown" in my project. Many thanks!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems fine.
However I wonder why doesn't the meteorgroup compile this changes somewhere? Using a private brotli upload seems a bit weird.
</dependencies> | ||
<repositories> | ||
<repository> | ||
<id>bintray-nitram509-jbrotli</id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better not rely on a private bintray repo, why is there no official build?
We released brotli support on our fork today. |
same issue. why is not merged? |
I needed Brotli compression recognition because I wanted to get some data from Facebook which use this algorithm.