add new entries from lib to development #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get all js files from lib folder and make it usable in dev mode - remove slash from entryName because its not allowed to have slash in filename
dsntzn
commented
Jan 16, 2020
| // replace slash for dash | ||
| // (slash is not allowed as a filename character) | ||
| // entryName is used for creating filename in webpack | ||
| .replace('/', '-'); |
There was a problem hiding this comment.
Inak by to bolo ze lib/file.js ze? Teraz to bude lib-file.js.
|
prečo tu boli popadané tie buildy? som to pozeral som to moc nechápal. to je ok? |
|
Nezistoval som to este, co sa v tom deje. My ziadne testy napisane nemame a tieto su z CRA, cize tam zrejme niekde vznika problem. |
|
je možné podľa tých errorov že tam nastal prípad kedy je akože entry option prázdny object čo by sa nemalo stávať len neviem kde presne nasimulovali pre react-scripts
… On 16 Jan 2020, at 16:03, Adam Močkoř ***@***.***> wrote:
Nezistoval som to este, co sa v tom deje. My ziadne testy napisane nemame a tieto su z CRA, cize tam zrejme niekde vznika problem.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#169?email_source=notifications&email_token=ABZGV26R6GFASOAHBOJ7XO3Q6BZMRA5CNFSM4KHUZS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJELZ4Y#issuecomment-575192307>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZGV22CJU42GPJWOEYXIHTQ6BZMRANCNFSM4KHUZS2A>.
|
|
❤️ |
|
Som to skusil v styleguide pustit a nedopadlo to moc dobre :) |
|
Ak je problem velkost suborov tak som si este vsimol ze index.js a static.js su napadne podobneale nie su rovnake tak rozmyslam ci sa dam nieco nejak neprepleta a potom to zdvojnasobuje kod.
… On 16 Jan 2020, at 17:45, Adam Močkoř ***@***.***> wrote:
Som to skusil v styleguide pustit a nedopadlo to moc dobre :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
jaj nevsimol som si ze to tam zmenilo slash na dash :D ok uz chapem. musime to nejako vymysliet teda inak.
… On 16 Jan 2020, at 17:45, Adam Močkoř ***@***.***> wrote:
Som to skusil v styleguide pustit a nedopadlo to moc dobre :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Jj to. Slash je v pohode znak v nazve suboru, indikuje folder :) To je vlastne presne to co chceme :) |
|
Uz so skusam v Lighter-app a je to tak dobre so slashom. |
|
ale mne so slashom v entryName vôbec nezobralo entry ako validné, keď tam slash nebol tak ho vzalo a posielalo ďalej do súborov. to bol jediný dôvod prečo som tie slashe dával preč. lebo inak sa proste súbor nedostal ďalej do assetov. tebe to tak ide so slashom? ak hej tak zajtra by som sa pozrel ako si to spravil.
… On 16 Jan 2020, at 18:45, Adam Močkoř ***@***.***> wrote:
Uz so skusam v Lighter-app a je to tak dobre so slashom.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#169?email_source=notifications&email_token=ABZGV27DALFFTAXZWSNVU43Q6CMMRA5CNFSM4KHUZS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJE56NA#issuecomment-575266612>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZGV23RIXLXPC4VGIU4SDDQ6CMMRANCNFSM4KHUZS2A>.
|
|
Toto filtruje files zo slashom. Je to zabudnuty pozostatok z Lighter 2 :( https://bitbucket.org/lightingbeetle/lighter-app/src/0fb4f4ff912f40caeb3d0f7abfc7867ea03e5f34/src/index.js#lines-93 |
|
no vidíš tak to som si nevšimol, že tam je. aj ja som checl aby mohlo byť lomítko v key ale som myslel že to reálne nejde. ak to ide tak nieje o čom.
… On 16 Jan 2020, at 21:26, Adam Močkoř ***@***.***> wrote:
Toto filtruje files zo slashom. Je to zabudnuty pozostatok z Lighter 2 :( https://bitbucket.org/lightingbeetle/lighter-app/src/0fb4f4ff912f40caeb3d0f7abfc7867ea03e5f34/src/index.js#lines-93 <https://bitbucket.org/lightingbeetle/lighter-app/src/0fb4f4ff912f40caeb3d0f7abfc7867ea03e5f34/src/index.js#lines-93>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#169?email_source=notifications&email_token=ABZGV27MK6FTNPOPX7MLM7DQ6C7GXA5CNFSM4KHUZS2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJFNYMI#issuecomment-575331377>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABZGV2Z2MPI4H7YGLQFXWSDQ6C7GXANCNFSM4KHUZS2A>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there was this problem with static js files not really showing up in a project anywhere else than in a build folder, so we need to make these files visible for development use