Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix styleguide not working in IE #54

Merged
merged 4 commits into from
Dec 18, 2018
Merged

fix styleguide not working in IE #54

merged 4 commits into from
Dec 18, 2018

Conversation

dsntzn
Copy link

@dsntzn dsntzn commented Dec 12, 2018

is working now but IE 10 has still some problems with content width.
there are not very nice scrollbars. but its better than nothing.

@adammockor
Copy link

adammockor commented Dec 14, 2018

screenshot 2018-12-14 at 10 05 35

Teraz mi tu vznikla takato medzera v Chrome :/ Medzi headerom a obsahom

@adammockor
Copy link

adammockor commented Dec 14, 2018

screenshot 2018-12-14 at 10 10 14
A v IE11 mam takuto chybu :/

npm install som pouzil :)

@dsntzn
Copy link
Author

dsntzn commented Dec 14, 2018

vyzerá že to je chyba babylonu. to znamená že

npm run prebuild treba spustiť

@dsntzn
Copy link
Author

dsntzn commented Dec 14, 2018

keby si si dal:

rm -rf node_modules; npm i;

tak prvý instal by ti spravil aj prebuild a build a šlo by to. takto to musíš sám spraviť.

ako to budeme riešiť? čo navrhuješ? dať do pred npm start vždicky?

@adammockor
Copy link

Ahaaa, na toto som zabudol. https://docs.npmjs.com/misc/scripts#examples postinstall by sa nedal pouzit?

@dsntzn
Copy link
Author

dsntzn commented Dec 17, 2018

skúsim nevedel som o post installe

@dsntzn
Copy link
Author

dsntzn commented Dec 17, 2018

je to tam potom aj sem píšem. neviem čo uvidíš skôr

@adammockor
Copy link

Vizualne to ale v Chrome stale odstakuje, ako som hore na screenshote ukazoval. Ale postinstall hook funguje pekne :)

@dsntzn
Copy link
Author

dsntzn commented Dec 18, 2018

vizuálne to neviem nasimulovať aby sa mi to správalo ako tebe. vieš mi dať nejaké bližšie info čo mám spraviť?
image

@dsntzn
Copy link
Author

dsntzn commented Dec 18, 2018

toto je IE 11 klikol som components a preview. nič viac.

@dsntzn
Copy link
Author

dsntzn commented Dec 18, 2018

skúšal som veľkosť obrazovky zmeniť. otvárať mobilné menu a meniť veľkosť pri otvorenom menu ale ani jeden use case nespravil to čo si mi screenshotol.

@adammockor
Copy link

adammockor commented Dec 18, 2018 via email

@dsntzn
Copy link
Author

dsntzn commented Dec 18, 2018

:D nie. Už to vidím. fixnem to. :) pozeral som IEčko. sorač.

@adammockor
Copy link

adammockor commented Dec 18, 2018 via email

@dsntzn
Copy link
Author

dsntzn commented Dec 18, 2018

je to tam. sticky na headeri robilo srandy.

@adammockor adammockor merged commit 274d72f into master Dec 18, 2018
@adammockor adammockor deleted the fix/styleguide-ie branch January 3, 2019 18:11
adammockor pushed a commit that referenced this pull request Oct 2, 2019
* fix styleguide not working in IE

* postinstall hook added to package.json

* fix weird spacing in chrome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants